Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid server.start() deprecation warning #661

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

rnons
Copy link
Contributor

@rnons rnons commented Sep 24, 2024

To reproduce, run yarn test serverClass in packages/nice-grpc

yarn run v1.22.22
$ jest serverClass
(node:28544) DeprecationWarning: Calling start() is no longer necessary. It can be safely omitted.
(Use `node --trace-deprecation ...` to show where the warning was created)
 PASS  src/__tests__/serverClass.ts

The DeprecationWarning is from https://github.com/grpc/grpc-node/blob/3c9436be8eb3788173796d4c90d2abe036d0f798/packages/grpc-js/src/server.ts#L1156-L1159

@aikoven
Copy link
Contributor

aikoven commented Sep 24, 2024

Thanks!

@aikoven aikoven merged commit bd5e82d into deeplay-io:master Sep 24, 2024
6 checks passed
@aikoven
Copy link
Contributor

aikoven commented Sep 24, 2024

Published 📦 nice-grpc@2.1.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants