Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] OP plugins for C++ interface #4041

Closed
njzjz opened this issue Aug 1, 2024 · 0 comments · Fixed by #4073
Closed

[Feature Request] OP plugins for C++ interface #4041

njzjz opened this issue Aug 1, 2024 · 0 comments · Fixed by #4073
Labels
enhancement

Comments

@njzjz
Copy link
Member

njzjz commented Aug 1, 2024

Summary

Customized OPs can be extended in the Python interface, but this mechanism doesn't exist in the C++ interface. The customized OP library is always required when running a customized model containing customized OPs.

Detailed Description

A mechanism similar to LAMMPS that finds plugins with the environment variables could be used.

Further Information, Files, and Links

No response
njzjz added a commit to njzjz/deepmd-kit that referenced this issue Aug 21, 2024
@njzjz
feat: load customized OP library in the C++ interface
de2ff1f 
Fix deepmodeling#4041.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz mentioned this issue Aug 21, 2024
Merged
@njzjz njzjz linked a pull request Aug 21, 2024 that will close this issue
feat: load customized OP library in the C++ interface #4073
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 26, 2024
@njzjz
feat: load customized OP library in the C++ interface (#4073)
bf4f203 
Fix #4041.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


- **New Features**
- Added documentation for integrating customized C++ operations (OPs) in
both PyTorch and TensorFlow models.
- Introduced guidelines on using the `DP_PLUGIN_PATH` environment
variable for loading custom OP libraries.
- Clarified the usage of environment variables in the context of a C++
interface, improving usability for third-party programs.

- **Documentation**
- Enhanced documentation to provide clearer instructions for model
development with custom C++ functionality.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz closed this as completed Aug 26, 2024
mtaillefumier pushed a commit to mtaillefumier/deepmd-kit that referenced this issue Sep 18, 2024
@njzjz @mtaillefumier
feat: load customized OP library in the C++ interface (deepmodeling#4073
2edcf11 
)

Fix deepmodeling#4041.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


- **New Features**
- Added documentation for integrating customized C++ operations (OPs) in
both PyTorch and TensorFlow models.
- Introduced guidelines on using the `DP_PLUGIN_PATH` environment
variable for loading custom OP libraries.
- Clarified the usage of environment variables in the context of a C++
interface, improving usability for third-party programs.

- **Documentation**
- Enhanced documentation to provide clearer instructions for model
development with custom C++ functionality.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: load customized OP library in the C++ interface njzjz/deepmd-kit
1 participant
@njzjz