Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump pyright to 1.1.363 #2232

Merged
merged 5 commits into from
May 17, 2024
Merged

chore: bump pyright to 1.1.363 #2232

merged 5 commits into from
May 17, 2024

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented May 16, 2024

Summary by CodeRabbit

  • Chores

    • Updated Pyright version in workflow from 1.1.308 to 1.1.363.
  • Refactor

    • Enhanced code readability and maintainability by adding type annotations to internal methods in _detect.py.
    • Improved clarity in data handling by adding type hints in the table printing function in _matrix.py.
  • Bug Fixes

    • Ensured proper handling of molecule creation and manipulation without type annotations in the convertSMILES method of the Path class in _path.py.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Copy link
Contributor

coderabbitai bot commented May 16, 2024

Important

Auto Review Skipped

Review was skipped as selected files did not have any reviewable changes.

Files selected but had no reviewable changes (1)
  • reacnetgenerator/py.typed

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The recent project updates involve enhancing type safety, readability, and compatibility. Changes include upgrading Pyright in the workflow, adding return type annotations in _detect.py, specifying types in _matrix.py, and removing type: ignore annotations in _path.py.

Changes

File Change Summary
.github/workflows/pyright.yml Updated Pyright version from 1.1.308 to 1.1.363.
reacnetgenerator/_detect.py Added return type annotations to _readNfunc and _readstepfunc methods in _Detect and _DetectLAMMPSbond classes.
reacnetgenerator/_matrix.py Modified _printtable to include species_idx variable declaration and specify index and columns explicitly in pd.DataFrame call.
reacnetgenerator/_path.py Removed type: ignore annotations from convertSMILES method for RDKit-related calls.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@njzjz njzjz changed the title chore: upgrade to the latest pyright chore: bump pyright to 1.1.363 May 16, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

reacnetgenerator/_matrix.py Outdated Show resolved Hide resolved
Copy link

codspeed-hq bot commented May 16, 2024

CodSpeed Performance Report

Merging #2232 will not alter performance

Comparing njzjz:pyright (323ade0) with master (311db70)

Summary

✅ 8 untouched benchmarks

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.18%. Comparing base (311db70) to head (323ade0).
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2232      +/-   ##
==========================================
- Coverage   95.23%   95.18%   -0.06%     
==========================================
  Files          18       17       -1     
  Lines        1448     1432      -16     
==========================================
- Hits         1379     1363      -16     
  Misses         69       69              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njzjz njzjz added this pull request to the merge queue May 17, 2024
Merged via the queue into deepmodeling:master with commit 8167e1a May 17, 2024
22 checks passed
@njzjz njzjz deleted the pyright branch May 17, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant