Stationary shadow in NeuButton #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dotrar
force-pushed
the
button-animation-fix
branch
from
4e76686
to
9b209fe
Compare
|
Also forgive me for any glaring mistakes because i am very new to dart / flutter, but I want to use NeuBrutalism in one of my projects so I'll try and give back any changes i make :) |
added 3 commits
November 9, 2023 14:24
This allows us to change the code in one place to affect all buttons that instaniate from NeuButton
This change allows the shadow to be stationary when the position of the button changes, making it look like the button is moving (relative to its background)
This makes it a more "satisfying" click movement rather than just a linear change
Dotrar
force-pushed
the
button-animation-fix
branch
from
9b209fe
to
b6b6392
Compare
|
This also works with different settings / offsets / for both icon and text buttons |
|
hey dude, thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY / Needs testing (I don't know how to do this other than just making sure example works)
Description
This change does two things:
a. abstract class
NeuButtoninwhichNeuTextButtonandNeuIconButtonderives from.b. fix animated builder so that it's not rebuilding every frame (pass in the child)
a. change
offsetduring animation so that the shadow looks stationary. this makes the effect that the button is moving relative to is background (previously, it was moving with the shadow.)b. Add a curve for
bounceInOutso that the button has a greater "pop" effect (subjective and perhaps could be done via a parameter passed to the constructor instead).Old Button:
New Button:
Type of Change
putting "bug fix" because of the moving shadows.