Merge pull request #27 from deepray-AI/recommendation

[DEBUG] hotfix
deepray-AI · Oct 17, 2023 · c7024ed · c7024ed
2 parents 0ebb2e5 + ad8f146
commit c7024ed
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/deepray/core/base_trainer.py b/deepray/core/base_trainer.py
@@ -527,7 +527,7 @@ def fit(
         ValueError: In case of mismatch between the provided input data
             and what the model expects or when the input data is empty.
     """
-    self.steps_per_epoch = steps_per_epoch if steps_per_epoch else 0
+    self.steps_per_epoch = steps_per_epoch if steps_per_epoch else -1
     if FLAGS.benchmark or FLAGS.stop_steps >= 0:
       if FLAGS.stop_steps >= 0:
         self.steps_per_epoch = FLAGS.stop_steps
@@ -895,7 +895,7 @@ def _test_step_fn(inputs):
       """Replicated accuracy calculation."""
       inputs, labels, sample_weight = data_adapter.unpack_x_y_sample_weight(inputs)
       model_outputs = self.model(inputs, training=False)
-      if labels and self.metric_container:
+      if labels is not None and self.metric_container:
         self.metric_container.update_state(labels, model_outputs, sample_weight=sample_weight)
       return model_outputs
 

diff --git a/modelzoo/Recommendation/criteo_ctr/run_horovod.sh b/modelzoo/Recommendation/criteo_ctr/run_horovod.sh
@@ -86,7 +86,6 @@ if [ $num_gpu -gt 1 ]; then
         --feature_map=feature_map_small.csv \
         --use_dynamic_embedding=True \
         --model_dir=${RESULTS_DIR} \
-        --model_export_path=${RESULTS_DIR} \
         --distribution_strategy=off \
         $use_fp16 $use_xla_tag
 fi