add comment about json serialization

deepset-ai · Sep 28, 2023 · 56c569d · 56c569d
1 parent ed48ccb
commit 56c569d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/e2e/preview/pipelines/test_extractive_qa_pipeline.py b/e2e/preview/pipelines/test_extractive_qa_pipeline.py
@@ -22,6 +22,7 @@ def test_extractive_qa_pipeline(tmp_path):
 
     qa_pipeline.draw(tmp_path / "test_extractive_qa_pipeline.png")
 
+    # TODO write to JSON to make sure it's actually serializable
     serialized_pipeline = qa_pipeline.to_dict()
     qa_pipeline = Pipeline.from_dict(serialized_pipeline)
 

diff --git a/e2e/preview/pipelines/test_rag_pipelines.py b/e2e/preview/pipelines/test_rag_pipelines.py
@@ -49,6 +49,7 @@ def test_bm25_rag_pipeline(tmp_path):
 
     rag_pipeline.draw(tmp_path / "test_bm25_rag_pipeline.png")
 
+    # TODO write to JSON to make sure it's actually serializable
     serialized_pipeline = rag_pipeline.to_dict()
     rag_pipeline = Pipeline.from_dict(serialized_pipeline)
 
@@ -122,6 +123,7 @@ def test_embedding_retrieval_rag_pipeline(tmp_path):
 
     rag_pipeline.draw(tmp_path / "test_embedding_rag_pipeline.png")
 
+    # TODO write to JSON to make sure it's actually serializable
     serialized_pipeline = rag_pipeline.to_dict()
     rag_pipeline = Pipeline.from_dict(serialized_pipeline)