Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prepare ES8 support by fixing 'cannot import RequestsHttpConnection' #2991

Closed
wants to merge 10 commits into from

Conversation

julian-risch
Copy link
Member

@julian-risch julian-risch commented Aug 8, 2022

Related Issues

Proposed Changes:

  • Pin elasticsearch client to version 8
  • Change ElasticSearchDocumentStore so that it works with version 8
  • Add an ElasticSearchDocumentStore7 class that inherits from ElasticSearchDocumentStore and works with version 7
  • Show deprecation warning if somebody uses ElasticSearchDocumentStore with version 7 and make sure it works nevertheless
  • Add tests for both version 7 and version 8
  • Unpin elasticsearch client version and decide on whether to keep elasticsearch and elastic_transport in standard Haystack dependencies

How did you test it?

Notes for the reviewer

Checklist

@nickchomey
Copy link
Contributor

FYI, ES 8.4 changed the ANN mechanism to use the _search endpoint. So, it might be worth pinning to that instead.

https://www.elastic.co/guide/en/elasticsearch/reference/current/release-highlights.html#integrate_ann_into_search_endpoint

@julian-risch julian-risch changed the title Pin elasticsearch to version 8.3.3 for testing Pin elasticsearch to version 8 for testing Nov 14, 2022
@julian-risch julian-risch marked this pull request as ready for review November 15, 2022 13:45
@julian-risch julian-risch requested a review from a team as a code owner November 15, 2022 13:45
@julian-risch julian-risch requested review from vblagoje and removed request for a team November 15, 2022 13:45
@julian-risch julian-risch marked this pull request as draft November 15, 2022 13:45
@julian-risch julian-risch self-assigned this Nov 16, 2022
@julian-risch julian-risch changed the title Pin elasticsearch to version 8 for testing feat: prepare ES8 support by fixing 'cannot import RequestsHttpConnection' Nov 16, 2022
@masci masci deleted the elasticsearch-8 branch September 13, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants