-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: extract elasticsearch
#4668
Conversation
Looks alright to me, I'd wait to merge #4602 before this one though. Also let's plan all the tutorials and docs edits before merging it maybe. |
Alright, I'll talk to @TuanaCelik and @bilgeyucel to see how to proceed with the tutorials forst. They have an issue open, but I think we should have a PR ready too. deepset-ai/haystack-tutorials#166 Regarding the docs, I'll check with the docs team and update this thread as well. |
Nice, makes sense to carve it out and make MemoryDocumentStore the go-to-doc-store for beginners/tutorials ...! Quick question: What error message do users see if they try to import |
@tholor they will see the same error they get from all other document stores, so:
See https://github.com/deepset-ai/haystack/blob/main/haystack/utils/import_utils.py#L56-L63 and https://github.com/deepset-ai/haystack/blob/main/haystack/document_stores/elasticsearch.py#L13 |
I added the |
* extract elasticsearch * update pyproject.toml * make more import optional * move MockBaseRetriever in conftest * install es in the es integration tests
* extract elasticsearch * update pyproject.toml * make more import optional * move MockBaseRetriever in conftest * install es in the es integration tests
Related Issues
elasticsearch
#4667Proposed Changes:
elasticsearch
into anelasticsearch
extra and add it to thedocstores
extraHow did you test it?
Notes for the reviewer
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.