Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: introduce a base class for ElasticsearchDocumentStore #5228

Merged
merged 6 commits into from
Jun 29, 2023

Conversation

masci
Copy link
Contributor

@masci masci commented Jun 29, 2023

Related Issues

Proposed Changes:

How did you test it?

unit tests, integration tests, manual verification

Notes for the reviewer

Checklist

@masci masci requested a review from a team as a code owner June 29, 2023 09:49
@masci masci requested review from ZanSara and removed request for a team June 29, 2023 09:49
@github-actions github-actions bot added the type:documentation Improvements on the docs label Jun 29, 2023
@masci masci requested a review from silvanocerza June 29, 2023 09:52
@masci masci added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Jun 29, 2023
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 5411442758

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 89 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 44.041%

Files with Coverage Reduction New Missed Lines %
document_stores/elasticsearch/es7.py 6 80.0%
document_stores/filter_utils.py 83 41.91%
Totals Coverage Status
Change from base Build 5410444095: -0.02%
Covered Lines: 10074
Relevant Lines: 22874

💛 - Coveralls

@masci masci merged commit d5c13aa into main Jun 29, 2023
@masci masci deleted the massi/es-base branch June 29, 2023 11:28
@ZanSara ZanSara removed their request for review July 5, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants