Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add elasticsearch7 and elasticsearch8 extra #5296

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Conversation

bogdankostic
Copy link
Contributor

Related Issues

Proposed Changes:

This PR adds the installation extras elasticsearch7 and elasticsearch8 and points the installation extra elasticsearch to elasticsearch7.

How did you test it?

I manually executed pip install .[elasticsearch], pip install .[elasticsearch7], and pip install .[elasticsearch8].

Notes for the reviewer

We decided that with Haystack 1.21, Elasticsearch 8 will become the default one and we will remove the extra elasticsearch8. Instead, the extra elasticsearch will install version 8 of the Elasticsearch client.

Checklist

@bogdankostic bogdankostic requested a review from a team as a code owner July 7, 2023 16:28
@bogdankostic bogdankostic requested review from vblagoje and removed request for a team July 7, 2023 16:28
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 5488535228

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 44.794%

Totals Coverage Status
Change from base Build 5487781909: 0.005%
Covered Lines: 10329
Relevant Lines: 23059

💛 - Coveralls

@bogdankostic bogdankostic merged commit 86d1fb5 into main Jul 10, 2023
51 checks passed
@bogdankostic bogdankostic deleted the es8_extra branch July 10, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants