build: Add elasticsearch7
and elasticsearch8
extra
#5296
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
This PR adds the installation extras
elasticsearch7
andelasticsearch8
and points the installation extraelasticsearch
toelasticsearch7
.How did you test it?
I manually executed
pip install .[elasticsearch]
,pip install .[elasticsearch7]
, andpip install .[elasticsearch8]
.Notes for the reviewer
We decided that with Haystack 1.21, Elasticsearch 8 will become the default one and we will remove the extra
elasticsearch8
. Instead, the extraelasticsearch
will install version 8 of the Elasticsearch client.Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.