Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Refactor some retriever tests into unit tests #5306

Merged
merged 5 commits into from
Jul 11, 2023
Merged

test: Refactor some retriever tests into unit tests #5306

merged 5 commits into from
Jul 11, 2023

Conversation

sjrl
Copy link
Contributor

@sjrl sjrl commented Jul 10, 2023

Related Issues

  • fixes N/A

Proposed Changes:

Refactored some retriever tests into unit tests.

Checklist

@sjrl sjrl requested a review from a team as a code owner July 10, 2023 12:12
@sjrl sjrl requested review from anakin87 and removed request for a team July 10, 2023 12:12
@coveralls
Copy link
Collaborator

coveralls commented Jul 10, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5518230485

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 169 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.4%) to 45.234%
Files with Coverage Reduction New Missed Lines %
nodes/retriever/dense.py 169 26.45%
Totals Coverage Status
Change from base Build 5505967772: 0.4%
Covered Lines: 10431
Relevant Lines: 23060
💛 - Coveralls

anakin87
anakin87 approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sjrl...
Thanks for adapting these tests!

I left a comment but nothing blocking...

test/nodes/test_retriever.py Outdated Show resolved Hide resolved
@sjrl sjrl merged commit 22750d3 into main Jul 11, 2023
49 checks passed
@sjrl sjrl deleted the retriever-tests branch July 11, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anakin87 anakin87 anakin87 approved these changes

Assignees
No one assigned
Labels
topic:retriever topic:tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sjrl @coveralls @anakin87