Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Improve token limit tests for OpenAI PromptNode layer #5351

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

vblagoje
Copy link
Member

@vblagoje vblagoje commented Jul 13, 2023

What?

This PR improves the unit tests for OpenAIInvocationLayer focusing on token limitation triggering (and not)

Why?

A user raised an issue in #5184, which appears to be unrelated. However, this presented an opportunity to enhance the unit tests for OpenAIInvocationLayer.

How it can be used?

This PR does not affect the functionality used by end-users. It solely enhances the internal testing mechanisms for the OpenAIInvocationLayer.

Notes for the reviewer

There are no code changes. The changes are about unit testing for OpenAIInvocationLayer.

@vblagoje vblagoje requested a review from a team as a code owner July 13, 2023 09:31
@vblagoje vblagoje requested review from ZanSara and removed request for a team July 13, 2023 09:31
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 5541466011

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall First build on open_ai_token_limits at 45.32%

Totals Coverage Status
Change from base Build 5541261748: 45.3%
Covered Lines: 10454
Relevant Lines: 23067

💛 - Coveralls

Copy link
Contributor

@ZanSara ZanSara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢

@vblagoje vblagoje merged commit adfabdd into main Jul 17, 2023
@vblagoje vblagoje deleted the open_ai_token_limits branch July 17, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants