ci: Fix typos discovered by codespell

[cclauss]

Related Issues

• fixes #issue-number

Proposed Changes:

https://pypi.org/project/codespell

How did you test it?

Notes for the reviewer

Checklist

• I have read the contributors guidelines and the code of conduct
• I have updated the related issue with new insights and changes
• I added unit tests and updated the docstrings
• I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.
• I documented my code
• I ran pre-commit hooks and fixed any issue

[silvanocerza]

I have some doubts about this.

I like this cause typos might make it harder to search for some words. On the other hand I wouldn't want to start a war on which is the correct way of writing a word. e.g color or colour

Another HUGE issue that I see is that this is focused on english only and doesn't understand the context nor whether it's actually trying to fix english or another language. See test/nodes/test_ranker.py as an example. It's trying to fix real german words. 😅

Not really sure whether to accept this or not to be fair. 😕

[coveralls]

Pull Request Test Coverage Report for Build 6173376004

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 48.966%

---

Totals
Change from base Build 6173046187:	0.0%
Covered Lines:	11818
Relevant Lines:	24135

---

💛 - Coveralls

[cclauss]

Skipped over the German content and would be easy to add colour to the ignores if it existed in this repo.

[tool.codespell]
ignore-words-list = "ans,astroid,nd,ned,nin,requeset,ue"
quiet-level = 3
skip = "./test/nodes/*,./test/others/*,./test/samples/*"

[dfokina]

From what I see here, except for the German words, everything it corrected in English is good and helpful, to be honest.
Looks like it uses US English, too, so even if it corrects colour to color, it would be actually in accordance with our guidelines @silvanocerza 👌
So I am not opposed to accepting this 🙂

[silvanocerza]

Cool for me then. 👍
I'll leave the final decision to you @dfokina.

[dfokina]

Approved 👍

[cclauss]

One lingering question... Was Requeset misspelled on purpose to make the assertion fail?

haystack/test/document_stores/test_opensearch.py

Line 1253 in 7194343

assert "Too Many Requeset" in caplog.text

[dfokina]

@silvanocerza ?

[silvanocerza]

Probably a typo copy and pasted, the actual log message is incorrect too.

haystack/haystack/document_stores/search_engine.py

Line 209 in 7194343

"Failed to insert a batch of '%s' documents because of a 'Too Many Requeset' response. "

[cclauss]

Fixed both.

[dfokina]

Also, some release notes are needed before merging this, I believe: https://github.com/deepset-ai/haystack/blob/main/CONTRIBUTING.md#release-notes

[silvanocerza]

No need for this in my opinion. I already marked the PR with the ignore-for-release-notes label.

[silvanocerza]

Linting is failing. Seems quite strange. 🤔

https://github.com/deepset-ai/haystack/actions/runs/6162226091/job/16723238817?pr=5778

I guess those changes have been done before introducing linting checks. We should fix them in a separate PR I think.

On a side note I fixed the license compliance workflow so it won't show as failing in PRs from forks. See #5791.

[cclauss]

Lint failures are fixed in #5783

I will remove reno entry despite #5778 (comment) and

haystack/.github/workflows/release_notes.yml

Line 19 in 55a2e7a

reno:

[silvanocerza]

Merged in main to get linting and license fixes.

[silvanocerza]

Let's goooo! 🚀

Thanks again! 🙏