-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Python performance improvements with ruff C4 and PERF fixes #5803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 6206023869
💛 - Coveralls |
masci
added
the
ignore-for-release-notes
PRs with this flag won't be included in the release notes.
label
Sep 14, 2023
masci
suggested changes
Sep 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor formatting issue, otherwise LGTM. Looking into the test failures now, it looks like a problem related to running from a fork.
Need another fix for the example tests but if you resolve the conflict this is good to go |
github-actions
bot
added
topic:pinecone
topic:images
topic:CI
type:documentation
Improvements on the docs
labels
Sep 15, 2023
cclauss
force-pushed
the
ruff_C4_and_PERF
branch
from
September 15, 2023 16:48
61cc125
to
564556a
Compare
github-actions
bot
added
topic:DX
Developer Experience
and removed
topic:images
topic:CI
labels
Sep 15, 2023
masci
approved these changes
Sep 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ignore-for-release-notes
PRs with this flag won't be included in the release notes.
topic:build/distribution
topic:dependencies
topic:document_store
topic:DX
Developer Experience
topic:elasticsearch
topic:file_converter
topic:modeling
topic:opensearch
topic:pipeline
topic:preprocessing
topic:promptnode
topic:reader
topic:retriever
topic:tests
type:documentation
Improvements on the docs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Make minor performance improvements to Python code with:
%
ruff --select=C4,PERF --fix .
Is there a way to run before vs. after benchmarks?
How did you test it?
Notes for the reviewer
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.