Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "ci: Speed up pylint GitHub Action" #5832

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Sep 16, 2023

Reverts #5828

@cclauss cclauss requested a review from a team as a code owner September 16, 2023 15:18
@cclauss cclauss requested review from julian-risch and removed request for a team September 16, 2023 15:18
@masci
Copy link
Contributor

masci commented Sep 18, 2023

I skimmed through the recent jobs but I couldn't find failures, before we merge this let me try debugging the job, maybe we're just missing a handful dependencies and we don't need to install all

@cclauss
Copy link
Contributor Author

cclauss commented Sep 18, 2023

https://github.com/deepset-ai/haystack/actions/runs/6219591285/job/16877952196

Run pylint -ry -j 0 haystack/preview/components/embedders/openai_text_embedder.py
************* Module haystack.preview.components.embedders.openai_text_embedder
haystack/preview/components/embedders/openai_text_embedder.py:4:0: E0401: Unable to import 'openai' (import-error)

There will be others...

@masci
Copy link
Contributor

masci commented Sep 18, 2023

My bad, for some reason I was looking at mypy, yeah the pylint error is not fixable, we need the dependencies to be there and I don't see an easy way to only install what's needed for a certain PR. Let's revert.

@masci masci merged commit 4112639 into deepset-ai:main Sep 18, 2023
7 checks passed
@cclauss cclauss deleted the revert-5828-speed-up-pylint branch September 18, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants