Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: e2e tests for RAG Pipelines #5876

Merged
merged 9 commits into from
Sep 26, 2023
Merged

test: e2e tests for RAG Pipelines #5876

merged 9 commits into from
Sep 26, 2023

Conversation

anakin87
Copy link
Member

Related Issues

Proposed Changes:

2 e2e tests, covering:

  • BM25 RAG Pipeline
  • Embedding Retrieval RAG Pipeline

How did you test it?

Local run

Checklist

@anakin87 anakin87 added ignore-for-release-notes PRs with this flag won't be included in the release notes. 2.x Related to Haystack v2.0 labels Sep 25, 2023
@anakin87 anakin87 requested a review from a team as a code owner September 25, 2023 16:38
@anakin87 anakin87 requested review from masci and removed request for a team September 25, 2023 16:38
Base automatically changed from relax-reader-integration-tests to main September 25, 2023 16:39
@coveralls
Copy link
Collaborator

coveralls commented Sep 25, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6310212093

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 49.875%
Totals Coverage Status
Change from base Build 6302282666: 0.004%
Covered Lines: 12216
Relevant Lines: 24493
💛 - Coveralls

ZanSara
ZanSara approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@ZanSara ZanSara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left one small comment, you can choose to apply it or not, it's not blocking

e2e/preview/pipelines/test_rag_pipelines.py Outdated Show resolved Hide resolved
@anakin87 @ZanSara
Update e2e/preview/pipelines/test_rag_pipelines.py
a1a361a 
Co-authored-by: ZanSara <sara.zanzottera@deepset.ai>
@anakin87 anakin87 merged commit e9d34fc into main Sep 26, 2023
70 checks passed
@anakin87 anakin87 deleted the rag-preview-e2e-test branch September 26, 2023 09:49
This was referenced Sep 28, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZanSara ZanSara ZanSara approved these changes

@masci masci Awaiting requested review from masci masci is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees
No one assigned
Labels
2.x Related to Haystack v2.0 ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anakin87 @coveralls @ZanSara