Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add preview extra to e2e tests #5898

Merged
merged 1 commit into from
Sep 27, 2023
Merged

fix: Add preview extra to e2e tests #5898

merged 1 commit into from
Sep 27, 2023

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented Sep 27, 2023

Related Issues

Proposed Changes:

  • Add preview extra to e2e tests

How did you test it?

n/a

Notes for the reviewer

Checklist

@ZanSara ZanSara added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Sep 27, 2023
@ZanSara ZanSara requested a review from a team as a code owner September 27, 2023 07:17
@ZanSara ZanSara requested review from masci and removed request for a team September 27, 2023 07:17
@ZanSara ZanSara requested review from julian-risch and removed request for masci September 27, 2023 07:18
julian-risch
julian-risch approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 And I see the end-to-end test workflow that you started is green too. 👍

@ZanSara ZanSara merged commit 6665e8e into main Sep 27, 2023
11 checks passed
@ZanSara ZanSara deleted the fix-e2e-preview-extra branch September 27, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julian-risch julian-risch julian-risch approved these changes

Assignees
No one assigned
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZanSara @julian-risch