test: enhance e2e tests to also draw and serialize/deserialize the test pipelines #5910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZanSara
added
the
ignore-for-release-notes
Pull Request Test Coverage Report for Build 6407362412
💛 - Coveralls |
ZanSara
commented
Sep 28, 2023
| @@ -121,7 +121,7 @@ def from_dict(cls, data: Dict[str, Any]) -> "GPTGenerator": | |||
| """ | |||
| init_params = data.get("init_parameters", {}) | |||
| streaming_callback = None | |||
| if "streaming_callback" in init_params: | |||
| if "streaming_callback" in init_params and init_params["streaming_callback"]: | |||
There was a problem hiding this comment.
This bug was found when I introduced serialization for the RAG pipelines. Maybe worth adding a unit test too?
There was a problem hiding this comment.
Yes please, in a separate PR.
julian-risch
approved these changes
Oct 4, 2023
| @@ -121,7 +121,7 @@ def from_dict(cls, data: Dict[str, Any]) -> "GPTGenerator": | |||
| """ | |||
| init_params = data.get("init_parameters", {}) | |||
| streaming_callback = None | |||
| if "streaming_callback" in init_params: | |||
| if "streaming_callback" in init_params and init_params["streaming_callback"]: | |||
There was a problem hiding this comment.
Yes please, in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
pipeline.draw()broken for components with objects in their state canals#108Proposed Changes:
e2e/preview/pipelines.How did you test it?
Notes for the reviewer
Bugs that are discovered should be fixed in parallel PRs before merging this one
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.