enhancement: reduced usage of numpy and substituted built-in libraries #8418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajit97singh
requested review from
dfokina and
silvanocerza
and removed request for
a team
github-actions
bot
added
topic:tests
type:documentation
ajit97singh
commented
Sep 30, 2024
| @@ -23,7 +21,6 @@ def set_all_seeds(seed: int, deterministic_cudnn: bool = False) -> None: | |||
| :param deterministic_cudnn: Enable for full reproducibility when using CUDA. Caution: might slow down training. | |||
| """ | |||
| random.seed(seed) | |||
| np.random.seed(seed) | |||
There was a problem hiding this comment.
Since numpy is no longer being used to generate random elements , we can safely remove this
ajit97singh
commented
Sep 30, 2024
| @@ -5,7 +5,6 @@ | |||
| import math | |||
| from typing import List | |||
|
|
|||
| import numpy as np | |||
There was a problem hiding this comment.
This particular file was importing numpy but no usage was found
|
@silvanocerza can you please review the changes |
Pull Request Test Coverage Report for Build 11404601053Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
@silvanocerza just a heads up that all tests have passed |
anakin87
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
numpyand use builtinmathwhen possible #8408Proposed Changes:
Reduced usage of numpy by substituting math and random libraries
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.