feat: Adding DALLE image generator #8448
Conversation
Pull Request Test Coverage Report for Build 11404564212Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
sjrl
requested review from
dfokina,
Amnah199 and
silvanocerza
and removed request for
a team
Co-authored-by: Silvano Cerza <3314350+silvanocerza@users.noreply.github.com>
| def warm_up(self) -> None: | ||
| """ | ||
| Warm up the OpenAI client. | ||
| """ | ||
| if self.client is None: | ||
| self.client = OpenAI( | ||
| api_key=self.api_key.resolve_value(), | ||
| organization=self.organization, | ||
| base_url=self.api_base_url, | ||
| timeout=self.timeout, | ||
| max_retries=self.max_retries, | ||
| ) |
There was a problem hiding this comment.
Can't we initialize the client in __init__? 🤔
There was a problem hiding this comment.
I'd prefer not to, I think it's better not to have to resolve the API key at init time. And only expect it at warm_up/run time.
If we put it in in the init it makes it hard to validate pipelines since we have to 1) make sure an api key is present and 2) when initializing the client I believe it complains if it is given an incorrect API key.
There was a problem hiding this comment.
Good point, we should probably create an issue to do the same for other Components.
Hmm interesting point, I'd rather wait on that when we have the conversation about how Haystack could generally support passing around images. For now this is just outputting directly the format from OpenAI. |
|
Also passing it back as a url or base64 it allows for embedding in markdown to view the image right away :) |
Related Issues
Proposed Changes:
Adds
DALLEImageGeneratorwhich calls OpenAI's image generation endpoint to generate images based on a prompt.How did you test it?
Added unit tests, more to come.
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.