Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(release-please): Fix pre-major bump #178

Closed
mike-winberry opened this issue Mar 26, 2024 · 0 comments · Fixed by #179
Closed

chore(release-please): Fix pre-major bump #178

mike-winberry opened this issue Mar 26, 2024 · 0 comments · Fixed by #179
Assignees
@mike-winberry
Labels
bug Something isn't working chore Any refactor or uncategorized chore.

Comments

@mike-winberry
Copy link
Collaborator

Describe what should be investigated or refactored

release please should be limited to MINOR and PATCH releases. Update the gh action to use the config file and ensure the config file variable names are up to date.

Links to any relevant code

https://github.com/defenseunicorns/go-oscal/blob/main/release-please-config.json
@mike-winberry mike-winberry self-assigned this Mar 26, 2024
@mike-winberry mike-winberry added chore Any refactor or uncategorized chore. bug Something isn't working labels Mar 26, 2024
@mike-winberry mike-winberry mentioned this issue Mar 26, 2024
Merged
5 tasks
@mike-winberry mike-winberry linked a pull request Mar 26, 2024 that will close this issue
chore(release-please-action): #178 fix release-please-config for v4 #179
Merged
5 tasks
mike-winberry added a commit that referenced this issue Mar 26, 2024
@mike-winberry
chore(release-please-action): #178 fix release-please-config for v4 (#…
c9d746f 
…179)

* chore(release-please): Update config with release-please-action v4 config options

* fix release-please-config

* fix release-please-config to follow v4 pattern

* Update release-please-action to latest version
@github-actions github-actions bot mentioned this issue Mar 26, 2024
Merged
CloudBeard pushed a commit that referenced this issue Mar 26, 2024
@mike-winberry @CloudBeard
chore(release-please-action): #178 fix release-please-config for v4 (#…
7550fa9 
…179)

* chore(release-please): Update config with release-please-action v4 config options

* fix release-please-config

* fix release-please-config to follow v4 pattern

* Update release-please-action to latest version
brandtkeller pushed a commit that referenced this issue Mar 28, 2024
@CloudBeard @mike-winberry @github-actions
chore(workflows): add triage label workflow (#184)
280247a 
* feat: add triage label automation

* add triage label doc

* fix(generate)!: embedded optional structs changed to pointers (#170)

* #131. fix(generate): now uses pointers for optional fields. update: all types.

* #131. refactor(generate): extract the pointer string logic into addPointerIfOptional method in generate_utils

* #131. update(generate): Primitives are no longer prefixed as pointers.

* chore(generate): #131. Add tests to ensure no additional json fields are being added when marshalling and unmarshalling using the generated types.

* docs(adr). #174. instantiated adr directory in docs. Add ADR for using pointers for non-primitive types

* docs(readme): update readme w/ pointer example.

* chore(release-please-action): #178 fix release-please-config for v4 (#179)

* chore(release-please): Update config with release-please-action v4 config options

* fix release-please-config

* fix release-please-config to follow v4 pattern

* Update release-please-action to latest version

* chore(main): release 0.3.0 (#180)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: Cole (Mike) Winberry <86802655+mike-winberry@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: mike-winberry <mike@defenseunicorns.com>
@github-actions github-actions bot mentioned this issue Apr 1, 2024
Closed
@github-actions github-actions bot mentioned this issue Apr 19, 2024
Merged
This was referenced May 20, 2024
Merged
Merged
@github-actions github-actions bot mentioned this issue Jun 6, 2024
Merged
This was referenced Jun 17, 2024
Merged
Merged
@github-actions github-actions bot mentioned this issue Aug 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mike-winberry mike-winberry

Labels
bug Something isn't working chore Any refactor or uncategorized chore.
Projects
Lula and Friends
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(release-please-action): #178 fix release-please-config for v4 defenseunicorns/go-oscal
1 participant
@mike-winberry