feat(validation): #217 handle multi model validation (not delimited) #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on into files.ReadOscalFile refactor(validation_command): extract the validition logic after reading oscal file into ValidationCommandWithModel
mike-winberry
commented
Jun 19, 2024
Comment on lines
+55
to
+68
| // Validate each model | ||
| for _, m := range models { | ||
| // get the key (model type), at this point is the only one | ||
| modelType, _ := model.GetModelType(m) | ||
|
|
||
| // TODO: get input on path format (current: multiple_model.json#component-definition) | ||
| pathWithType := fmt.Sprintf("%s#%s", inputFile, modelType) | ||
| validationResponse, err := ValidationCommandWithModel(pathWithType, m) | ||
| // TODO: should we bail on non-validation errors? | ||
| if err != nil { | ||
| return responses, err | ||
| } | ||
| responses = append(responses, validationResponse) | ||
| } |
There was a problem hiding this comment.
Specific feedback/thoughts requested marked by TODO
|
@CloudBeard Should be enough there to see what changes or additional functionality you might want. @defenseunicorns/lula-dev Not sure about the
|
mike-winberry
added
enhancement
|
Closing as it is no longer relevant. |
mike-winberry
deleted the
217-featvalidation-handle-multi-model-validation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#217
Type of change
Checklist before merging