Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oscal schema updates support #28

Merged
merged 7 commits into from
Sep 22, 2023
Merged

Conversation

brandtkeller
Copy link
Member

Attempted to generate types for 1.1.1 release of OSCAL component definition. It resulted in a lot of hard-coded assumptions breaking.

Introducing the use of jsonschema-go has hopefully made the codebase more robust and I successfully tested generation of Component Definitions from 1.0.4 -> 1.1.1

Lot's of cleanup and improvement to do. Goal here is functional code that works for all releases of component definition 1.0.4 -> 1.1.1.

This opens the doors to conversations like if there would be value/requirements for OSCAL tooling to be able to be functional for current and historical schemas of OSCAL. There may be additional logic that we can add here and expose to make de-duplication possible while referencing multiple specific versions. Creating additional issues for TODO items in the backlog.

@brandtkeller brandtkeller added bug Something isn't working enhancement New feature or request labels Sep 20, 2023
@brandtkeller brandtkeller self-assigned this Sep 20, 2023
@brandtkeller
Copy link
Member Author

Marking ready for review and will be opening issues to capture work around schema validation that needs to occur with anyOf/allOf items and existence of enums.

@brandtkeller brandtkeller marked this pull request as ready for review September 21, 2023 14:14
Copy link

@Alvin-zzz Alvin-zzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the hard work!

@brandtkeller brandtkeller merged commit a3fd6f3 into main Sep 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants