Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempted to generate types for
1.1.1
release of OSCAL component definition. It resulted in a lot of hard-coded assumptions breaking.Introducing the use of jsonschema-go has hopefully made the codebase more robust and I successfully tested generation of Component Definitions from 1.0.4 -> 1.1.1
Lot's of cleanup and improvement to do. Goal here is functional code that works for all releases of component definition
1.0.4
->1.1.1
.This opens the doors to conversations like if there would be value/requirements for OSCAL tooling to be able to be functional for current and historical schemas of OSCAL. There may be additional logic that we can add here and expose to make de-duplication possible while referencing multiple specific versions. Creating additional issues for
TODO
items in the backlog.