Feat: Aggregate by control-id #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandtkeller
requested review from
CloudBeard,
mike-winberry and
Alvin-zzz
as code owners
✅ Deploy Preview for lula-docs canceled.
|
CloudBeard
approved these changes
Dec 11, 2023
This was referenced Jun 29, 2024
This was referenced Jul 12, 2024
This was referenced Aug 5, 2024
This was referenced Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #161
Removing temporary objects between component-definitions and the creation of assessment results. Now we generate the required findings and observations during validation directly and pass them to generate the assessment-results model around.
This also unblocks #160 as it makes
control-idunique - meaning we can compare two results and expect the state of a single finding to reflect all validations against that control-id.