fix: 197 add input-file flag validation for validate command #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitry Kisler <admin@dkisler.com>
kislerdm
requested review from
brandtkeller,
CloudBeard,
mike-winberry and
Alvin-zzz
as code owners
✅ Deploy Preview for lula-docs canceled.
|
kislerdm
changed the title
brandtkeller
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
Why it was decided to use cobra for such a simple CLI?
No particularly strong opinion outside of alignment with other closely related open source projects and potential command vendoring options in the future.
Should behavioural tests be considered for the CLI flags? For context, automated tests for the f flag won't give much value now, but assuming long-term vision (based on the cobra framework), behavioural tests for all flags/commands might be beneficial.
I love the idea. We're working on more command testing that would align well to that benefit
Nonetheless - Very much appreciate this contribution to Lula!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #197
What changed
-ffor thevalidatecommand.Why do we need it
Questions
cobrafor such a simple CLI?fflag won't give much value now, but assuming long-term vision (based on thecobraframework), behavioural tests for all flags/commands might be beneficial.