Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#278. Upgrade go-oscal package. #283

Merged

Conversation

mike-winberry
Copy link
Collaborator

@mike-winberry mike-winberry commented Feb 29, 2024

Upon release of go-oscal v0.2.0 we will want to update Lula.

Purpose

Types have changed and updating the output of Lula to produce oscal version 1.1.2 documents as aligned with the latest release of OSCAL is our goal.

Objectives

  • Any modifications to data types used (Should only be component-definition and assessment-results at this time)
  • Update the OSCAL_VERSION constant for assessment-results
  • Update component-definitions in the e2e tests to 1.1.2

…2. Fix types that changed since last go-oscal release. Replace time w/ time.Time()
@mike-winberry mike-winberry linked an issue Feb 29, 2024 that may be closed by this pull request
Copy link

netlify bot commented Feb 29, 2024

Deploy Preview for lula-docs ready!

Name Link
🔨 Latest commit f698026
🔍 Latest deploy log https://app.netlify.com/sites/lula-docs/deploys/65e0f383d7897c0008320719
😎 Deploy Preview https://deploy-preview-283--lula-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 50 (🟢 up 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@mike-winberry mike-winberry marked this pull request as ready for review February 29, 2024 19:49
.vscode/settings.json Outdated Show resolved Hide resolved
@brandtkeller brandtkeller self-assigned this Mar 1, 2024
@brandtkeller brandtkeller added this to the v0.1.0 release milestone Mar 1, 2024
Copy link
Member

@brandtkeller brandtkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any outliers as far as the types go 👍

@brandtkeller brandtkeller merged commit 1a6fe85 into main Mar 1, 2024
7 checks passed
@brandtkeller brandtkeller deleted the 278-update-lula-to-using-the-latest-version-of-go-oscal branch March 1, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Update Lula to using the latest version of go-oscal
2 participants