Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps(go-oscal): upgrade to v0.3.0 #317

Merged
merged 12 commits into from
Apr 1, 2024
Merged

deps(go-oscal): upgrade to v0.3.0 #317

merged 12 commits into from
Apr 1, 2024

Conversation

mike-winberry
Copy link
Collaborator

@mike-winberry mike-winberry commented Mar 19, 2024 •
edited
Loading

  • Updated all go-oscal references to use pointers (where appropriate).
  • Update to go-oscal v0.3.0

@netlify Netlify
Copy link

netlify bot commented Mar 19, 2024 •
edited
Loading

✅ Deploy Preview for lula-docs canceled.

Name Link
🔨 Latest commit cf44461
🔍 Latest deploy log https://app.netlify.com/sites/lula-docs/deploys/6606d2c07f6bbf0008ab62f8

mike-winberry
mike-winberry commented Mar 19, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@mike-winberry mike-winberry changed the title upgrade(go-oscal): to use new pointer types. All tests passing. [WIP] upgrade(go-oscal): to use new pointer types. All tests passing. Mar 19, 2024
@mike-winberry mike-winberry changed the title [WIP] upgrade(go-oscal): to use new pointer types. All tests passing. [WIP] upgrade(go-oscal): to use new pointer types. Mar 19, 2024
@mike-winberry mike-winberry mentioned this pull request Mar 19, 2024
Merged
3 tasks
@mike-winberry mike-winberry mentioned this pull request Mar 26, 2024
Closed
1 task
@mike-winberry mike-winberry changed the title [WIP] upgrade(go-oscal): to use new pointer types. deps(go-oscal): upgrade to v0.3.0 Mar 27, 2024
@mike-winberry mike-winberry marked this pull request as ready for review March 27, 2024 00:06
@mike-winberry
chore: create pkg/oscal/component_test.go and initial tests for oscal
05507fb 
upgrade
refactor(pkg/oscal/component): to begin handling nil pointers correctly
@mike-winberry mike-winberry marked this pull request as draft March 27, 2024 04:50
@mike-winberry mike-winberry marked this pull request as ready for review March 27, 2024 16:33
@mike-winberry mike-winberry requested a review from a team as a code owner March 27, 2024 16:33
@mike-winberry mike-winberry self-assigned this Mar 27, 2024
brandtkeller
brandtkeller approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@brandtkeller brandtkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated assessment-results outputs between v0.1.0 and this branch are consistent. Glad to have this change in before we start the heavy lifting of generation.

@brandtkeller brandtkeller merged commit b8e80cc into main Apr 1, 2024
7 checks passed
@brandtkeller brandtkeller deleted the test_go-oscal_pointers branch April 1, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandtkeller brandtkeller brandtkeller approved these changes

@meganwolf0 meganwolf0 meganwolf0 approved these changes

@CloudBeard CloudBeard Awaiting requested review from CloudBeard

Assignees

@mike-winberry mike-winberry

Labels
None yet
Projects
Lula and Friends
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mike-winberry @brandtkeller @meganwolf0