-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Establish workflow for lula validation identifiers #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for lula-docs canceled.
|
brandtkeller
requested review from
mike-winberry,
CloudBeard and
meganwolf0
as code owners
April 10, 2024 19:57
meganwolf0
previously approved these changes
Apr 11, 2024
mike-winberry
requested changes
Apr 11, 2024
mike-winberry
approved these changes
Apr 11, 2024
meganwolf0
approved these changes
Apr 12, 2024
CloudBeard
approved these changes
Apr 12, 2024
This was referenced Jul 12, 2024
This was referenced Aug 5, 2024
This was referenced Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #226
Improving the validation identifiers to improve the developer experience and reduce potential errors due to miss identifying a link.
Changes
BackMatterToMap()
now strictly provides a map[string]string object for which identified validations will then be unmarshalled and placed in thevalidationMap
.back-matter
validationrel
for which we could expand to include validation "types"validationMap
serves future external processing - such that when an external document is unmarshalled, we can place 1 -> N validations into the map rather than having to open the same file multiple times for different validations (reuse).