feat!(compose): add ability to pull and compose import component defs #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abilities Refactor and rename unit tests for clarity and consistency Add new unit test for imported component definitions
✅ Deploy Preview for lula-docs canceled.
|
…ions in a remote file
…HrefIds, SetHrefIds as they were unused and create AddLulaValidation func fix(oscal/component): update BackMatterTopMap to return an instantiated map if the backmatter is nil refactor(validate): update ValidateOnCompDef to use the new simplified validationstore tests: update related tests
mike-winberry
requested review from
brandtkeller,
CloudBeard and
meganwolf0
as code owners
mike-winberry
changed the title
meganwolf0
approved these changes
May 7, 2024
CloudBeard
approved these changes
May 8, 2024
mike-winberry
deleted the
381-consume-import-component-definition-hrefs-for-validation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to support the imported-component-definition field in oscal
ComponentDefinition, functionality has been added to fetch and merge imported component definitions into their parent component definition....
Related Issue
#381
Type of change
Checklist before merging