fix(validate): fix order of assessment-results results #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandtkeller
requested review from
mike-winberry,
CloudBeard and
meganwolf0
as code owners
✅ Deploy Preview for lula-docs canceled.
|
mike-winberry
approved these changes
May 23, 2024
This was referenced May 24, 2024
This was referenced Jun 29, 2024
This was referenced Jul 12, 2024
This was referenced Aug 5, 2024
This was referenced Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
lula evaluateto a single file assumes that the latest results are being prepended to the array of results. For now this means we need to put the append latest results before original. Updated test to reflect the order required.Will file an issue surrounding how Lula will identify a threshold that is not the second result in the array (current assumption).
Related Issue
Fixes #436
Type of change
Checklist before merging