Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trim whitespace bug #677

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

CloudBeard
Copy link
Collaborator

Description

Trimming the whitespace in the addPart function fixes the format issues in the bug below.

It did create a new issue with indenting nested assessment objectives so added the quick fix for that.

Related Issue

Fixes # #676

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@CloudBeard CloudBeard changed the title trim whitespace and fix indention issue from trimming whitespace fix: trim whitespace bug Sep 20, 2024
@CloudBeard CloudBeard marked this pull request as ready for review September 20, 2024 19:26
@CloudBeard CloudBeard requested a review from a team as a code owner September 20, 2024 19:26
Copy link
Member

@brandtkeller brandtkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested changes with:

./bin/lula generate component -c https://raw.githubusercontent.com/usnistgov/oscal-content/master/nist.gov/SP800-53/rev5/json/NIST_SP-800-53_rev5_catalog.json -r ac-1,ac-2,ac-3,ac-3.2,ac-4 -o oscal-component.yaml --remarks assessment-objective

And seeing ac-2 remarks being generated properly.

I don't see a discernible difference between the loop syntax but have no issues with the change either.

@brandtkeller brandtkeller merged commit e30a824 into main Sep 20, 2024
5 checks passed
@brandtkeller brandtkeller deleted the 676-trim-leading-whitespace-in-addPart-Label branch September 20, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants