Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: add maru=true variable and refactoring #97

Merged
merged 42 commits into from
May 22, 2024
Merged

refactor!: add maru=true variable and refactoring #97

merged 42 commits into from
May 22, 2024

Conversation

ericwyles
Copy link
Contributor

@ericwyles ericwyles commented May 22, 2024 •
edited by Racer159
Loading

Description

This PR adds a MARU=true variable to running tasks and includes some refactoring / rebranding.

The following ⚠️ breaking changes are included in this PR:

  • config.EnvPrefix has been changed from the variable run to the constant MARU now and is no longer modifiable by applications vendoring in the runner. This means any variable replacements that previously used <EnvPrefix>_<VariableName> will only work for MARU_<VariableName> now.
    • The function config.AddExtraEnv(key string, value string) has been added to allow applications vendoring maru to add arbitrary environment variables since the EnvPrefix can no longer be modified.
  • The configuration search path $HOME/.run has been replaced with $HOME/.maru
  • The configuration file name has been changed from run-config to maru-config
  • Templating is no longer being performed on 'cmd' values and is being left to the shell to expand environment variables.

Related Issue

Fixes #78

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Racer159 and others added 30 commits May 8, 2024 16:25
@Racer159
chore: de-zarfify maru-runner
ee56e77
@Racer159
fix some linting
d54329c
@Racer159
fix env var handling
fd48372
@Racer159
fix variable loading
be0cace
@Racer159
remove files and fix list all
a266924
@Racer159
remove zarf completely
3f1c8c3
@Racer159
fix lint and little errors
98440da
@Racer159
fix some nice-to-haves
9ac65de
@Racer159
switch variables to internal
b35aca3
@Racer159
switch variables to internal
e11cb0a
@ericwyles
unit tests target
a2e2a68
@Racer159
remove zarf specific things
5203fde
@Racer159
remove text template
b0a70e8
@Racer159
switch variables to have generics
abef76b
@Racer159
resolve lint and Makefile *isms
3fcc592
@Racer159
segment runaction logic out of runner
44718d3
@Racer159
fix actions test
a34b491
@Racer159
add cmd mutation check in case they are already set
d2e5df0
@Racer159
fix schema
c831651
@Racer159
test schema workflow
5a30461
@Racer159
fix schema workflow
226222d
@Racer159
fix schema
a1891ba
@Racer159
remove zarf grype ignores
cc7912d
@Racer159
add dependency review workflow
4e8b002
@Racer159
update more zarf references
e1a8865
@Racer159
fix issue templates
7d26500
@Racer159
fix lints
fc47b74
@Racer159
update to released exec
5107679
@ericwyles
add MARU=true environment variable, refactor, and add tests
63e2410
@ericwyles
merge conflicts
3c1334d
@ericwyles ericwyles changed the title Maru env var and refactor refactor: Add MARU=true variable and refactoring May 22, 2024
@ericwyles ericwyles added breaking-change 💔 This introduces a breaking change documentation Improvements or additions to documentation enhancement ✨ New feature or request labels May 22, 2024
@ericwyles ericwyles changed the title refactor: Add MARU=true variable and refactoring fix: Add MARU=true variable and refactoring May 22, 2024
@ericwyles ericwyles changed the title fix: Add MARU=true variable and refactoring refactor: add maru=true variable and refactoring May 22, 2024
@ericwyles ericwyles marked this pull request as ready for review May 22, 2024 20:57
@ericwyles ericwyles requested a review from a team as a code owner May 22, 2024 20:57
Racer159
Racer159 requested changes May 22, 2024
View reviewed changes
src/pkg/runner/actions.go Outdated Show resolved Hide resolved
src/pkg/runner/actions.go Outdated Show resolved Hide resolved
src/config/config.go Outdated Show resolved Hide resolved
src/test/tasks/tasks.yaml Show resolved Hide resolved
Racer159
Racer159 requested changes May 22, 2024
View reviewed changes
src/config/config.go Outdated Show resolved Hide resolved
src/pkg/runner/actions.go Outdated Show resolved Hide resolved
src/pkg/utils/template.go Show resolved Hide resolved
src/pkg/runner/actions_test.go Outdated Show resolved Hide resolved
src/pkg/runner/actions_test.go Outdated Show resolved Hide resolved
src/pkg/runner/actions_test.go Outdated Show resolved Hide resolved
src/pkg/utils/tempate_test.go Outdated Show resolved Hide resolved
src/pkg/runner/actions_test.go Outdated Show resolved Hide resolved
Racer159
Racer159 requested changes May 22, 2024
View reviewed changes
src/pkg/runner/actions_test.go Outdated Show resolved Hide resolved
@Racer159 Racer159 changed the title refactor: add maru=true variable and refactoring refactor!: add maru=true variable and refactoring May 22, 2024
@ericwyles ericwyles merged commit 5cf570f into main May 22, 2024
10 checks passed
@ericwyles ericwyles deleted the maru-env-var-and-refactor branch May 22, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Racer159 Racer159 Racer159 approved these changes

Assignees
No one assigned
Labels
breaking-change 💔 This introduces a breaking change documentation Improvements or additions to documentation enhancement ✨ New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Identifier for when commands are run inside of a task
2 participants
@ericwyles @Racer159