ON HOLD: store expects base64 encoded keys #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
5 tasks
cmwylie19
changed the title
cmwylie19
added a commit
to defenseunicorns/pepr
that referenced
this pull request
Jul 23, 2024
## Description This PR Migrates the Store to a v2 data path, migrates keys from previous version before a read of the CR, patches them to v2, then starts a watch. It also adds fuzzing, property-based, more unit and journey tests. <img width="690" alt="image" src="https://github.com/defenseunicorns/pepr/assets/1096507/9b9522ad-2724-4579-866d-f73424e34991"> ## Related Issue Fixes #915 <!-- or --> Relates to PR defenseunicorns/pepr-excellent-examples#46 updating the e2e test to expect the keys base64 encoded ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [x] [Contributor Guide Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request) followed --------- Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com> Co-authored-by: Barrett <81570928+btlghrants@users.noreply.github.com>
|
we already fixed this in another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store now encodes keys so the expect would look like this:
[23:51:51.704] INFO (77258): observed updates: [ { "YQ==": "1", "Yg==": "2", "Yw==": "3", "b2JzZXJ2ZWQ=": "yay" }