-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: configure gitaly with recommended resiliency settings #238
Merged
JoeHCQ1
merged 15 commits into
main
from
221-configure-gitaly-with-recommended-resiliency-settings
Nov 6, 2024
Merged
feat: configure gitaly with recommended resiliency settings #238
JoeHCQ1
merged 15 commits into
main
from
221-configure-gitaly-with-recommended-resiliency-settings
Nov 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobbmay
reviewed
Oct 29, 2024
|
@bburky this is where we're giving Gitaly the keys to the kingdom. |
bburky
reviewed
Nov 6, 2024
packages/additional-manifests/pepr-policy-exemptions/gitlab-exemptions.yaml
Show resolved
Hide resolved
packages/additional-manifests/pepr-policy-exemptions/gitlab-exemptions.yaml
Show resolved
Hide resolved
JoeHCQ1
changed the title
draft: configure gitaly with recommended resiliency settings
feat: configure gitaly with recommended resiliency settings
Nov 6, 2024
jacobbmay
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
JoeHCQ1
deleted the
221-configure-gitaly-with-recommended-resiliency-settings
branch
November 6, 2024 22:19
This was referenced Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a Pepr policy exemption to enable cgroups, added cgroups variable, added other recommended settings from https://docs.gitlab.com/ee/administration/gitaly/kubernetes.html
Problems:
Note, the only "testing" I forsee being possible in this setup is verifying that the settings took. Fail behavior would require overwhelming our massive gitaly node.