Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrated HA-valkey configuration #240

Merged

Conversation

JoeHCQ1
Copy link
Contributor

@JoeHCQ1 JoeHCQ1 commented Nov 7, 2024

Integrated HA Valkey into our bundle. This required updating the valkey and gitlab packages to the latest versions to get needed upstream changes.

Changes needed by the GitLab update:

  • Fixed init security context re: GitLab update where they restricted those by default.
  • Overrode a new value to ensure the gitlab object store secret isn't overwritten with Minio default values (the zarf variable wasn't seeming to work)
  • Added zarf var so registry bucket wasn't hardcoded value. Technically the bucket has always been wrong in dev and test, but the update meant the registry doesn't become healthy if it can't find it's bucket. Used to not care.

Other:

  • Changed Valkey's namespace to gitlab-valkey for future friendliness. GitLab doesn't require that we migrate caches so no downstream impacts.
  • Removed gitaly security context because it's just restating the upstream SC.
  • Removed the gitaly cgroups PSC declaration because it can only be fixed upstream, se pending PR: https://github.com/defenseunicorns/uds-package-gitlab/pull/246/files

Some of the "other" changes mean that we can get the gitaly init cgroups working again as soon as that PR is merged and a release cut.

@JoeHCQ1 JoeHCQ1 requested a review from a team as a code owner November 7, 2024 16:33
@JoeHCQ1 JoeHCQ1 linked an issue Nov 7, 2024 that may be closed by this pull request
@JoeHCQ1 JoeHCQ1 marked this pull request as draft November 7, 2024 16:34
@JoeHCQ1 JoeHCQ1 marked this pull request as ready for review December 5, 2024 17:55
@JoeHCQ1 JoeHCQ1 changed the title feat: added vars and defaults for valkey feat: integrated HA-valkey configuration Dec 5, 2024
@JoeHCQ1 JoeHCQ1 self-assigned this Dec 5, 2024
JoeHCQ1 and others added 3 commits December 5, 2024 16:18
Co-authored-by: jacobbmay <134300709+jacobbmay@users.noreply.github.com>
Signed-off-by: Joseph Richardson <49208786+JoeHCQ1@users.noreply.github.com>
…potentially-cache

Signed-off-by: Joseph Richardson <49208786+JoeHCQ1@users.noreply.github.com>
Signed-off-by: Joseph Richardson <49208786+JoeHCQ1@users.noreply.github.com>
Copy link
Collaborator

@jacobbmay jacobbmay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoeHCQ1 JoeHCQ1 merged commit 346eb17 into main Dec 5, 2024
1 check passed
@JoeHCQ1 JoeHCQ1 deleted the 220-enable-3k-user-count-via-valkey-cluster-potentially-cache branch December 5, 2024 21:30
@jacobbmay jacobbmay restored the 220-enable-3k-user-count-via-valkey-cluster-potentially-cache branch December 6, 2024 21:14
jacobbmay added a commit that referenced this pull request Dec 6, 2024
JoeHCQ1 pushed a commit that referenced this pull request Dec 6, 2024
This was referenced Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable 3k user count via valkey cluster & potentially cache
2 participants