-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrated HA-valkey configuration #240
Merged
JoeHCQ1
merged 20 commits into
main
from
220-enable-3k-user-count-via-valkey-cluster-potentially-cache
Dec 5, 2024
Merged
feat: integrated HA-valkey configuration #240
JoeHCQ1
merged 20 commits into
main
from
220-enable-3k-user-count-via-valkey-cluster-potentially-cache
Dec 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…potentially-cache
JoeHCQ1
changed the title
feat: added vars and defaults for valkey
feat: integrated HA-valkey configuration
Dec 5, 2024
jacobbmay
reviewed
Dec 5, 2024
Co-authored-by: jacobbmay <134300709+jacobbmay@users.noreply.github.com> Signed-off-by: Joseph Richardson <49208786+JoeHCQ1@users.noreply.github.com>
…potentially-cache Signed-off-by: Joseph Richardson <49208786+JoeHCQ1@users.noreply.github.com>
Signed-off-by: Joseph Richardson <49208786+JoeHCQ1@users.noreply.github.com>
jacobbmay
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
JoeHCQ1
deleted the
220-enable-3k-user-count-via-valkey-cluster-potentially-cache
branch
December 5, 2024 21:30
jacobbmay
restored the
220-enable-3k-user-count-via-valkey-cluster-potentially-cache
branch
December 6, 2024 21:14
JoeHCQ1
pushed a commit
that referenced
this pull request
Dec 6, 2024
This was referenced Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrated HA Valkey into our bundle. This required updating the valkey and gitlab packages to the latest versions to get needed upstream changes.
Changes needed by the GitLab update:
Other:
gitlab-valkey
for future friendliness. GitLab doesn't require that we migrate caches so no downstream impacts.Some of the "other" changes mean that we can get the gitaly init cgroups working again as soon as that PR is merged and a release cut.