Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure smoke tests cover both pre-existing cluster and no pre-existing cluster test cases #940

Closed
UncleGedd opened this issue Sep 23, 2024 · 0 comments · Fixed by #944
Closed

Comments

@UncleGedd
Copy link
Collaborator

Context

When we attempted to release the UDS state feature, our release pipeline caught a bug where state was being created in a cluster that existed before deploying the slim-dev bundle.

This bug should have been caught sooner by the nightly pipelines but was not. Noting that the bug was caught because our release pipeline starts up a cluster using the k3d action which deploys an empty k3d cluster.

Describe what should be investigated or refactored

Smoke tests in our release pipeline vs nightly-uds-core are slightly different.

  • In our release-pipeline, we use the our k3d Github action to download the k3d binary and start a k3d cluster (ref). Because of this, 2 clusters get created in the Github runner
  • In our nightly-uds-core smoke test, we install k3d but do not start a k3d cluster; in this case, only 1 cluster is created

There are 2 scenarios that should be tested in both pipelines:

  1. Cluster already exists when we deploy slim-dev
  2. Cluster does not already exist when we deploy slim-dev

Update the smoke tests to cover the above scenarios in both nightly and release pipelines (can potentially create a resuable workflow to avoid duplicates configs)

@catsby catsby added this to the v0.17.0 milestone Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants