-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: split override envs properly #829
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjnagel
requested review from
UncleGedd,
jeff-mccoy,
decleaver and
TristanHoladay
as code owners
July 19, 2024 13:52
UncleGedd
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
holy geez that's a good find, really appreicate this 🚀
mjnagel
referenced
this pull request
in defenseunicorns/uds-core
Jul 24, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [defenseunicorns/uds-cli](https://togithub.com/defenseunicorns/uds-cli) | minor | `0.12.0` -> `0.13.1` | | [defenseunicorns/uds-cli](https://togithub.com/defenseunicorns/uds-cli) | minor | `v0.12.0` -> `v0.13.1` | --- ### Release Notes <details> <summary>defenseunicorns/uds-cli (defenseunicorns/uds-cli)</summary> ### [`v0.13.1`](https://togithub.com/defenseunicorns/uds-cli/releases/tag/v0.13.1) [Compare Source](https://togithub.com/defenseunicorns/uds-cli/compare/v0.13.0...v0.13.1) #### What's Changed - fix: nightly release typo and add checksums by [@​UncleGedd](https://togithub.com/UncleGedd) in [https://github.com/defenseunicorns/uds-cli/pull/828](https://togithub.com/defenseunicorns/uds-cli/pull/828) - fix: split override envs properly by [@​mjnagel](https://togithub.com/mjnagel) in [https://github.com/defenseunicorns/uds-cli/pull/829](https://togithub.com/defenseunicorns/uds-cli/pull/829) **Full Changelog**: defenseunicorns/uds-cli@nightly-unstable...v0.13.1 ### [`v0.13.0`](https://togithub.com/defenseunicorns/uds-cli/releases/tag/v0.13.0) [Compare Source](https://togithub.com/defenseunicorns/uds-cli/compare/v0.12.0...v0.13.0) ##### What's Changed - chore(deps): update github/codeql-action action to v3.25.11 by [@​renovate](https://togithub.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/744](https://togithub.com/defenseunicorns/uds-cli/pull/744) - chore(deps): update actions/create-github-app-token action to v1.10.3 by [@​renovate](https://togithub.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/747](https://togithub.com/defenseunicorns/uds-cli/pull/747) - chore(deps): update module github.com/prometheus/common to v0.55.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/666](https://togithub.com/defenseunicorns/uds-cli/pull/666) - chore(deps): update homebrew/actions digest to [`c9f08ac`](https://togithub.com/defenseunicorns/uds-cli/commit/c9f08ac) by [@​renovate](https://togithub.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/746](https://togithub.com/defenseunicorns/uds-cli/pull/746) - fix(deps): update module github.com/charmbracelet/lipgloss to v0.11.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/712](https://togithub.com/defenseunicorns/uds-cli/pull/712) - chore: add schema validation docs by [@​UncleGedd](https://togithub.com/UncleGedd) in [https://github.com/defenseunicorns/uds-cli/pull/748](https://togithub.com/defenseunicorns/uds-cli/pull/748) - feat: show overrides for deployers by [@​TristanHoladay](https://togithub.com/TristanHoladay) in [https://github.com/defenseunicorns/uds-cli/pull/674](https://togithub.com/defenseunicorns/uds-cli/pull/674) - chore: adds an ADR for bundle OCI media types by [@​UncleGedd](https://togithub.com/UncleGedd) in [https://github.com/defenseunicorns/uds-cli/pull/750](https://togithub.com/defenseunicorns/uds-cli/pull/750) - fix: make dev deploy help msg better by [@​UncleGedd](https://togithub.com/UncleGedd) in [https://github.com/defenseunicorns/uds-cli/pull/756](https://togithub.com/defenseunicorns/uds-cli/pull/756) - chore: caching refactor by [@​decleaver](https://togithub.com/decleaver) in [https://github.com/defenseunicorns/uds-cli/pull/751](https://togithub.com/defenseunicorns/uds-cli/pull/751) - feat: make runner output prettier in CI by [@​UncleGedd](https://togithub.com/UncleGedd) in [https://github.com/defenseunicorns/uds-cli/pull/758](https://togithub.com/defenseunicorns/uds-cli/pull/758) - chore: refactor overrides by [@​TristanHoladay](https://togithub.com/TristanHoladay) in [https://github.com/defenseunicorns/uds-cli/pull/753](https://togithub.com/defenseunicorns/uds-cli/pull/753) - chore(deps): update actions/download-artifact action to v4.1.8 by [@​renovate](https://togithub.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/764](https://togithub.com/defenseunicorns/uds-cli/pull/764) - feat: name and version flags on create + generates CLI docs by [@​UncleGedd](https://togithub.com/UncleGedd) in [https://github.com/defenseunicorns/uds-cli/pull/768](https://togithub.com/defenseunicorns/uds-cli/pull/768) - chore(deps): update actions/setup-node action to v4.0.3 by [@​renovate](https://togithub.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/769](https://togithub.com/defenseunicorns/uds-cli/pull/769) - chore(deps): update anchore/sbom-action action to v0.16.1 by [@​renovate](https://togithub.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/771](https://togithub.com/defenseunicorns/uds-cli/pull/771) - chore(deps): update docker/setup-buildx-action action to v3.4.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/762](https://togithub.com/defenseunicorns/uds-cli/pull/762) - fix(deps): update module golang.org/x/mod to v0.19.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/763](https://togithub.com/defenseunicorns/uds-cli/pull/763) - chore(deps): update actions/upload-artifact action to v4.3.4 by [@​renovate](https://togithub.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/765](https://togithub.com/defenseunicorns/uds-cli/pull/765) - chore: ensure stdout for inspect \[FLAGS] by [@​TristanHoladay](https://togithub.com/TristanHoladay) in [https://github.com/defenseunicorns/uds-cli/pull/759](https://togithub.com/defenseunicorns/uds-cli/pull/759) - fix(deps): update module github.com/charmbracelet/lipgloss to v0.11.1 by [@​renovate](https://togithub.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/774](https://togithub.com/defenseunicorns/uds-cli/pull/774) - chore(deps): update actions/setup-go action to v5.0.2 by [@​renovate](https://togithub.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/773](https://togithub.com/defenseunicorns/uds-cli/pull/773) - chore(deps): update actions/dependency-review-action action to v4.3.4 by [@​renovate](https://togithub.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/779](https://togithub.com/defenseunicorns/uds-cli/pull/779) - chore(deps): update github/codeql-action action to v3.25.12 by [@​renovate](https://togithub.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/781](https://togithub.com/defenseunicorns/uds-cli/pull/781) - chore: more overrides refactors by [@​TristanHoladay](https://togithub.com/TristanHoladay) in [https://github.com/defenseunicorns/uds-cli/pull/761](https://togithub.com/defenseunicorns/uds-cli/pull/761) - feat: upgrade Maru to 0.2.2 by [@​UncleGedd](https://togithub.com/UncleGedd) in [https://github.com/defenseunicorns/uds-cli/pull/783](https://togithub.com/defenseunicorns/uds-cli/pull/783) - chore(deps): update zarf to v0.36.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/777](https://togithub.com/defenseunicorns/uds-cli/pull/777) - fix: task schema generation using maru and removing runner tests by [@​decleaver](https://togithub.com/decleaver) in [https://github.com/defenseunicorns/uds-cli/pull/778](https://togithub.com/defenseunicorns/uds-cli/pull/778) **Full Changelog**: defenseunicorns/uds-cli@v0.12.0...v0.13.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/defenseunicorns/uds-core). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Micah Nagel <micah.nagel@defenseunicorns.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Splits envs into 2 sections explicitly, handling situations where envs have
=
in them.Also updated the base64 secret test to include
=
since this is a common place where this could occur (base64 padding).Related Issue
No issue opened, can be if required.
Type of change
Checklist before merging