-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure cluster disconnect doesn't break deploy and remove ops #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UncleGedd
requested review from
jeff-mccoy,
decleaver,
TristanHoladay and
catsby
as code owners
September 5, 2024 21:05
UncleGedd
changed the title
fix: ensure cluster disconnect doesn't break deploys and removes
fix: ensure cluster disconnect doesn't break deploy and remove ops
Sep 6, 2024
UncleGedd
force-pushed
the
fix-no-cluster
branch
from
September 6, 2024 01:25
56a3e70
to
11768f7
Compare
decleaver
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good checks for testing
TristanHoladay
approved these changes
Sep 6, 2024
mjnagel
referenced
this pull request
in defenseunicorns/uds-core
Sep 6, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [defenseunicorns/uds-cli](https://redirect.github.com/defenseunicorns/uds-cli) | minor | `0.14.2` -> `0.15.0` | | [defenseunicorns/uds-cli](https://redirect.github.com/defenseunicorns/uds-cli) | minor | `v0.14.2` -> `v0.15.0` | --- ### Release Notes <details> <summary>defenseunicorns/uds-cli (defenseunicorns/uds-cli)</summary> ### [`v0.15.0`](https://redirect.github.com/defenseunicorns/uds-cli/releases/tag/v0.15.0) [Compare Source](https://redirect.github.com/defenseunicorns/uds-cli/compare/v0.14.2...v0.15.0) ##### What's Changed - fix: ensure cluster disconnect doesn't break deploy and remove ops by [@​UncleGedd](https://redirect.github.com/UncleGedd) in [https://github.com/defenseunicorns/uds-cli/pull/908](https://redirect.github.com/defenseunicorns/uds-cli/pull/908) - fix(deps): update zarf to v0.39.0 by [@​renovate](https://redirect.github.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/907](https://redirect.github.com/defenseunicorns/uds-cli/pull/907) - chore(deps): update actions/create-github-app-token action to v1.10.4 by [@​renovate](https://redirect.github.com/renovate) in [https://github.com/defenseunicorns/uds-cli/pull/895](https://redirect.github.com/defenseunicorns/uds-cli/pull/895) - fix: cleanup color and typo by [@​catsby](https://redirect.github.com/catsby) in [https://github.com/defenseunicorns/uds-cli/pull/906](https://redirect.github.com/defenseunicorns/uds-cli/pull/906) - feat: adds feature flag to state by [@​UncleGedd](https://redirect.github.com/UncleGedd) in [https://github.com/defenseunicorns/uds-cli/pull/909](https://redirect.github.com/defenseunicorns/uds-cli/pull/909) - fix: remove uds core nightly state checks for now by [@​UncleGedd](https://redirect.github.com/UncleGedd) in [https://github.com/defenseunicorns/uds-cli/pull/910](https://redirect.github.com/defenseunicorns/uds-cli/pull/910) **Full Changelog**: defenseunicorns/uds-cli@nightly-unstable...v0.15.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/defenseunicorns/uds-core). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ensure cluster disconnect doesn't break deploys and removes
Adds test to UDS core smoke test nightly, proof of passing:
Related Issue
Fixes #903