Skip to content

Commit

Permalink
remove ignorance check for unset vars
Browse files Browse the repository at this point in the history
  • Loading branch information
Racer159 committed Oct 3, 2024
1 parent 8543a79 commit 78b0c2f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
1 change: 1 addition & 0 deletions .github/workflows/commitlint.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,5 @@ jobs:
pull_request_title: ${{ github.event.pull_request.title }}
run: |
echo "module.exports = {extends: ['@commitlint/config-conventional']}" > commitlint.config.js
# shellcheck disable=SC2154
echo "$pull_request_title" | npx commitlint
3 changes: 1 addition & 2 deletions tasks/lint.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,7 @@ tasks:
# -e SC2001 Ignore sed replace suggestions (${text//search/replacement} syntax doesn't support regex so this suggestion often won't work)
# -e SC2002 Ignore rejection of `cat |` (redirection syntax is not always familiar to developers and while cat _could_ not exist that is extremely unlikely)
# -e SC2181 Ignore rejection of $? ($? can be confusing in some circumstances but also more readable in others with more complex commands)
# -e SC2154 Ignore unset variables (in many cases env vars will come from the environment and we should assume they are set)
export SHELLCHECK_OPTS="-x -e SC2016 -e SC2050 -e SC2001 -e SC2002 -e SC2181 -e SC2154"
export SHELLCHECK_OPTS="-x -e SC2016 -e SC2050 -e SC2001 -e SC2002 -e SC2181"
# Function to lint scripts inside `---` delimited files
lint_scripts() {
Expand Down

0 comments on commit 78b0c2f

Please sign in to comment.