Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert "chore: support deselection of metrics-server" #196

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

mjnagel
Copy link
Contributor

@mjnagel mjnagel commented Feb 21, 2024

Reverts #193

Reverting this due to zarf-dev/zarf#2320

Resolves #195

Also added a temporary task addition to make sure that tasks can run and succeed.

@mjnagel mjnagel requested a review from a team as a code owner February 21, 2024 16:43
TristanHoladay
TristanHoladay previously approved these changes Feb 21, 2024
@mjnagel mjnagel self-assigned this Feb 21, 2024
Copy link
Contributor

@zachariahmiller zachariahmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@MxNxPx MxNxPx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mjnagel mjnagel merged commit 25a408d into main Feb 21, 2024
8 checks passed
@mjnagel mjnagel deleted the revert-193-metrics-server-default branch February 21, 2024 17:25
mjnagel pushed a commit that referenced this pull request Feb 21, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.13.1](v0.13.0...v0.13.1)
(2024-02-21)


### Bug Fixes

* revert "chore: support deselection of metrics-server"
([#196](#196))
([25a408d](25a408d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
robmcelvenny pushed a commit to owen-grady/uds-core-slim-dev that referenced this pull request Jun 3, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.13.1](defenseunicorns/uds-core@v0.13.0...v0.13.1)
(2024-02-21)


### Bug Fixes

* revert "chore: support deselection of metrics-server"
([#196](defenseunicorns/uds-core#196))
([25a408d](defenseunicorns/uds-core@25a408d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics-server fails to load image from 0.13.0 OCI release
4 participants