fix: batch authservice checksum updates #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@UnicornChance Did you take a stab at addressing at batching authservice updates across multiple packages? IMO I don't think this is worth doing unless we address that scenario. I don't think we have anyone who currently using more than one sso client per Package. I would try to debounce whatever function is actually checksuming the deployment and that would probably work. |
UnicornChance
commented
Oct 17, 2024
UnicornChance
commented
Oct 17, 2024
UnicornChance
commented
Oct 17, 2024
UnicornChance
commented
Oct 17, 2024
mjnagel
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Reviewed synchronously with @rjferguson21 - this behaves as expected in testing and LGTM. Definitely a good feature/change to track with users - we may want to capture the reconcile strategy change in the description and/or PR title as well.
5 tasks
rjferguson21
pushed a commit
that referenced
this pull request
Oct 28, 2024
🤖 I have created a release *beep* *boop* --- ## [0.30.0](v0.29.1...v0.30.0) (2024-10-28) ### ⚠ BREAKING CHANGES * remove uds-runtime from core ([#955](#955)) ### Features * add finalizer for UDS Package CRs ([#953](#953)) ([fa42714](fa42714)) * adds registry1 flavor of uds runtime ([#925](#925)) ([0011852](0011852)) ### Bug Fixes * batch authservice checksum updates ([#735](#735)) ([100d35b](100d35b)) * logout redirect uri ([#945](#945)) ([8e2b5d8](8e2b5d8)) * resolve lingering note formatting ([#938](#938)) ([455a530](455a530)) * vector remap language logic typo ([#959](#959)) ([89af729](89af729)) ### Miscellaneous * add proper version update to aks nightly bundle ([#942](#942)) ([2f51c75](2f51c75)) * block local auth for neuvector ([#965](#965)) ([8f25b41](8f25b41)) * **deps:** update vector to 0.42.0 ([#946](#946)) ([2f63db2](2f63db2)) * remove uds-runtime from core ([#955](#955)) ([c6f6664](c6f6664)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently we update the authservice secret and apply a checksum each time a chain is added, updated or deleted. This ends up resulting in unnecessary churn on Authservice and also can be problematic when we switch to the
kindNsNamebased queues for Pepr (multiple authservice clients can reconcile concurrently).The changes in this PR switch to using an in-memory secret for tracking chain changes (rather than pulling from the cluster on each change) as well as debouncing updates so that concurrent chain creations are batched together.
Related Issue
Fixes #561
Type of change
Checklist before merging