Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace dev-redis package in the test bundle with uds-package-valkey #150

Closed
zachariahmiller opened this issue Jun 13, 2024 · 3 comments
Closed

Replace dev-redis package in the test bundle with uds-package-valkey #150

zachariahmiller opened this issue Jun 13, 2024 · 3 comments
Assignees
@Racer159
Labels
tech-debt 💳

Comments

@zachariahmiller
Copy link
Contributor

Describe what should be investigated or refactored

Now that we have a uds package for valkey, we should replace the dev-redis package being pulled into the bundle.
@zachariahmiller zachariahmiller self-assigned this Jul 1, 2024
@Racer159 Racer159 mentioned this issue Jul 3, 2024
Merged
5 tasks
@Racer159 Racer159 assigned Racer159 and unassigned zachariahmiller Jul 3, 2024
@Racer159
Copy link
Contributor

Racer159 commented Jul 3, 2024

We should test what happens when you go from a redis-based bundle to a valkey based one

@Racer159
Copy link
Contributor

Racer159 commented Jul 3, 2024

This should just work as long as no bg jobs are running but we should call this out as a potential gotcha
https://docs.gitlab.com/ee/administration/backup_restore/backup_gitlab.html#other-data

@Racer159
Copy link
Contributor

Racer159 commented Jul 3, 2024

While doing this should upgrade postgres to a newer version (17 adds support for later versions)

@Racer159 Racer159 mentioned this issue Jul 3, 2024
Merged
5 tasks
Racer159 added a commit to defenseunicorns/uds-package-valkey that referenced this issue Jul 8, 2024
@Racer159
feat: allow for native package secret copying (#16)
2e54bd7 
## Description

This allows for secret copying to another namespace to align the
deployment pattern with PGO

## Related Issue

Relates to
defenseunicorns/uds-package-gitlab#150

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [X] Test, docs, adr added or updated as needed
- [X] [Contributor Guide
Steps](https://github.com/defenseunicorns/uds-package-valkey/blob/main/CONTRIBUTING.md#developer-workflow)
followed
Racer159 added a commit that referenced this issue Jul 9, 2024
@Racer159
feat!: allow redis password secret creation and GitLab PeerAuthentica…
a5e9bd1 
…tion exceptions (#161)

## Description

This updates GL to be able to take in a Redis password and use Valkey in
its test bundle.

It also updates GL to have its own peer authentication exceptions if
using internal psql / valkey

> [!WARNING]
> **Breaking Change**: the default connection to `dev-redis` has been
changed to `valkey` - if you were using the `dev-redis` package you must
update these values.

## Related Issue

Relates to #150

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [X] Test, docs, adr added or updated as needed
- [X] [Contributor Guide
Steps](https://github.com/defenseunicorns/uds-package-gitlab/blob/main/CONTRIBUTING.md#developer-workflow)
followed
Release-As: v17.1.1-uds.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Racer159 Racer159

Labels
tech-debt 💳
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

150-replace-dev-redis-package-in-the-test-bundle-with-uds-package-valkey defenseunicorns/uds-package-gitlab
2 participants
@Racer159 @zachariahmiller