Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove hardcoded architecture in zarf packages #29

Merged

Conversation

zachariahmiller
Copy link
Contributor

@zachariahmiller zachariahmiller commented Feb 10, 2024

remove arch in zarf.yamls
support lower footprint dev deploy
add flavor matrix to publish step
remove unused images (from disabled dep charts) from zarf.yaml
add only.cluster.architecture: amd64 to registry1 flavor

@zachariahmiller zachariahmiller requested a review from a team as a code owner February 10, 2024 15:25
@zachariahmiller zachariahmiller changed the title chore: 23 remove hardcoded architecture in zarf packages Draft: chore: 23 remove hardcoded architecture in zarf packages Feb 10, 2024
@zachariahmiller
Copy link
Contributor Author

The current registry1 pipeline is passing on this and the upstream amd64 is deploying successfully on my homelab I havent been able to verify arm yet, see previous comment.

@zachariahmiller
Copy link
Contributor Author

Wasn't able to get darwin arm deploying including when i reduced the requests and replicas based on this https://gitlab.com/gitlab-org/charts/gitlab/-/blob/master/examples/values-gke-minimum.yaml and some trial and error.

IIRC is was the webservice container wouldnt come up fully and there were 502 errors trying to hit the health check endpoint on the istio proxy sidecar.

FWIW, at least without istio, gitlab expects one to be able to develop on m series mac w/ colima with far less resources than i was using. Even adding the specs in this list to what i was deploying all of uds core on previously wasnt working. https://docs.gitlab.com/charts/development/kind/#building-the-vm

The config is the same regardless of arch and upstream is working on amd64. Outside of this context, istio is working on arm64, so not really sure what the culprit is here ☹️

It might be worth testing this on a graviton instance, or if we end up getting the arm runner beta access to confirm if this issue is seen on arm64 in general or if it is limited to darwin arm. It also might be worth testing the actual upstream gitlab chart instead of repo1 on top of k3d-istio with the uds package cr as that is the chart gitlab would expect to work with 4 cores and 16gb ram per the above link.

I'm trying the test one more time with the request bumped up for the webservice and using the otherwise "minimal" config. Assuming that doesnt work I'll table this and clean up this PR to be merged.

@zachariahmiller
Copy link
Contributor Author

zachariahmiller commented Feb 12, 2024

Of course i write up a bunch of info about it not working and then got it working. I used the values from the gke minimal values link above, with the request for just the webservice bumped back up:

gitlab:
  webservice:
    minReplicas: 1
    resources:
      limits:
       memory: 2.5G
      requests:
        cpu: 300m
        memory: 2.5G

and deployed successfully and was able to access gitlab.uds.dev. This was with 1 server and 1 agent. Will remove the agent and see if it is still successful.

@zachariahmiller
Copy link
Contributor Author

Confirmed working on darwin_arm with the single server k3d config. 😎

@Racer159 Racer159 marked this pull request as draft February 12, 2024 19:16
@zachariahmiller zachariahmiller marked this pull request as ready for review February 13, 2024 22:50
@zachariahmiller zachariahmiller changed the title Draft: chore: 23 remove hardcoded architecture in zarf packages chore: remove hardcoded architecture in zarf packages Feb 13, 2024
@zachariahmiller zachariahmiller changed the title chore: remove hardcoded architecture in zarf packages fix: remove hardcoded architecture in zarf packages Feb 13, 2024
@zachariahmiller
Copy link
Contributor Author

zachariahmiller commented Feb 13, 2024

This also completes #21 and #17

@zachariahmiller zachariahmiller linked an issue Feb 13, 2024 that may be closed by this pull request
@zachariahmiller zachariahmiller linked an issue Feb 13, 2024 that may be closed by this pull request
Copy link
Contributor

@mjnagel mjnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yamllint does not like some things (trailing spaces, indentation, extra newlines, etc) but this LGTM and worked on my Mac.

@zachariahmiller
Copy link
Contributor Author

thanks @mjnagel

@zachariahmiller
Copy link
Contributor Author

created issue to add the lint check #31

@zachariahmiller zachariahmiller merged commit 2c4e869 into main Feb 14, 2024
3 checks passed
@zachariahmiller zachariahmiller self-assigned this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup the root zarf.yaml imports Publish flavors of uds-package-gitlab
3 participants