-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove hardcoded architecture in zarf packages #29
fix: remove hardcoded architecture in zarf packages #29
Conversation
Signed-off-by: Zachariah Miller <zachariah.miller@defenseunicorns.com>
The current registry1 pipeline is passing on this and the upstream amd64 is deploying successfully on my homelab I havent been able to verify arm yet, see previous comment. |
Wasn't able to get darwin arm deploying including when i reduced the requests and replicas based on this https://gitlab.com/gitlab-org/charts/gitlab/-/blob/master/examples/values-gke-minimum.yaml and some trial and error. IIRC is was the webservice container wouldnt come up fully and there were 502 errors trying to hit the health check endpoint on the istio proxy sidecar. FWIW, at least without istio, gitlab expects one to be able to develop on m series mac w/ colima with far less resources than i was using. Even adding the specs in this list to what i was deploying all of uds core on previously wasnt working. https://docs.gitlab.com/charts/development/kind/#building-the-vm The config is the same regardless of arch and upstream is working on amd64. Outside of this context, istio is working on arm64, so not really sure what the culprit is here It might be worth testing this on a graviton instance, or if we end up getting the arm runner beta access to confirm if this issue is seen on arm64 in general or if it is limited to darwin arm. It also might be worth testing the actual upstream gitlab chart instead of repo1 on top of k3d-istio with the uds package cr as that is the chart gitlab would expect to work with 4 cores and 16gb ram per the above link. I'm trying the test one more time with the request bumped up for the webservice and using the otherwise "minimal" config. Assuming that doesnt work I'll table this and clean up this PR to be merged. |
Of course i write up a bunch of info about it not working and then got it working. I used the values from the gke minimal values link above, with the request for just the webservice bumped back up: gitlab:
webservice:
minReplicas: 1
resources:
limits:
memory: 2.5G
requests:
cpu: 300m
memory: 2.5G and deployed successfully and was able to access gitlab.uds.dev. This was with 1 server and 1 agent. Will remove the agent and see if it is still successful. |
Confirmed working on darwin_arm with the single server k3d config. 😎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yamllint does not like some things (trailing spaces, indentation, extra newlines, etc) but this LGTM and worked on my Mac.
thanks @mjnagel |
created issue to add the lint check #31 |
remove arch in zarf.yamls
support lower footprint dev deploy
add flavor matrix to publish step
remove unused images (from disabled dep charts) from zarf.yaml
add
only.cluster.architecture: amd64
to registry1 flavor