Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make metrics configuration optional since it requires enterprise license #103

Closed
zachariahmiller opened this issue Jul 1, 2024 · 0 comments · Fixed by #108
Closed

Make metrics configuration optional since it requires enterprise license #103

zachariahmiller opened this issue Jul 1, 2024 · 0 comments · Fixed by #108
Assignees
@zachariahmiller
Labels
tech-debt 💳

Comments

@zachariahmiller
Copy link
Contributor

Describe what should be investigated or refactored

Currently we configure metrics for mattermost by default. The configuration pattern works, but then when there is no license the monitor isnt healthy in prometheus because the metrics featrue is locked behind a license. To resolve this we need to add a conditional in the CR so that metrics are able to be enabled/disabled to prevent the unhealthy endpoint from being there when not using a license.

Additional context

@mjnagel Raised this up after encountering it in a staging environment.
@zachariahmiller zachariahmiller self-assigned this Jul 1, 2024
@zachariahmiller zachariahmiller mentioned this issue Jul 9, 2024
Merged
5 tasks
@zachariahmiller zachariahmiller linked a pull request Jul 9, 2024 that will close this issue
fix: make monitoring optional based on license #108
Merged
5 tasks
zachariahmiller added a commit that referenced this issue Jul 9, 2024
@zachariahmiller @Racer159
fix: make monitoring optional based on license (#108)
783c05e 
## Description

make monitoring optional based on license due to licensing restrictions.

## Related Issue

Fixes #
#103

## Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [ ] Test, docs, adr added or updated as needed
- [ ] [Contributor Guide
Steps](https://github.com/defenseunicorns/uds-package-mattermost/blob/main/CONTRIBUTING.md#developer-workflow)
followed

---------

Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zachariahmiller zachariahmiller

Labels
tech-debt 💳
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: make monitoring optional based on license defenseunicorns/uds-package-mattermost
1 participant
@zachariahmiller