-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add basic smoke test for mattermost with sso #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marshall007
force-pushed
the
playwright-test
branch
from
May 14, 2024 17:57
83eea13
to
38c9c68
Compare
zachariahmiller
commented
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marshall007 see comments. It wont let me request changes since i created the PR.
Racer159
reviewed
May 14, 2024
marshall007
reviewed
May 15, 2024
marshall007
force-pushed
the
playwright-test
branch
2 times, most recently
from
May 16, 2024 19:35
3a8ef5b
to
38e85b3
Compare
This fixes a hardcoded redirect uri Fixes # <!-- or --> Relates to # - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) - [ ] Test, docs, adr added or updated as needed - [ ] [Contributor Guide Steps](https://github.com/defenseunicorns/uds-package-mattermost/blob/main/CONTRIBUTING.md#developer-workflow) followed --------- Co-authored-by: Michael-Kruggel <michael.kruggel@defenseunicorns.com> Co-authored-by: Micah Nagel <micah.nagel@defenseunicorns.com>
... Fixes # <!-- or --> Relates to # - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) - [ ] Test, docs, adr added or updated as needed - [ ] [Contributor Guide Steps](https://github.com/defenseunicorns/uds-package-mattermost/blob/main/CONTRIBUTING.md#developer-workflow) followed --------- Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- [9.7.2-uds.2](v9.7.2-uds.1...v9.7.2-uds.2) (2024-05-13) * pre-commit yaml lint config and postgres config error ([#74](#74)) ([47c4760](47c4760)) * replaced hardcoded redirectUri ([#73](#73)) ([1390dcd](1390dcd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
... Fixes # <!-- or --> Relates to # - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) - [ ] Test, docs, adr added or updated as needed - [ ] [Contributor Guide Steps](https://github.com/defenseunicorns/uds-package-mattermost/blob/main/CONTRIBUTING.md#developer-workflow) followed --------- Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>
marshall007
force-pushed
the
playwright-test
branch
from
May 20, 2024 20:22
cf0720e
to
d39d00d
Compare
Racer159
requested changes
May 20, 2024
Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>
Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>
Racer159
approved these changes
May 21, 2024
Racer159
pushed a commit
that referenced
this pull request
May 22, 2024
🤖 I have created a release *beep* *boop* --- ## [9.8.0-uds.0](v9.7.2-uds.2...v9.8.0-uds.0) (2024-05-22) ### Features * add oidc option for sso ([#77](#77)) ([9228ee8](9228ee8)) ### Miscellaneous * add basic smoke test for mattermost with sso ([#65](#65)) ([074749c](074749c)), closes [#75](#75) * **deps:** update mattermost package dependencies ([#61](#61)) ([a7c0adb](a7c0adb)) * **deps:** update mattermost support dependencies ([#66](#66)) ([eab55f5](eab55f5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Basic testing using playwright for Mattermost SSO