-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix bundle path variable on release #79
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oates
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Racer159
pushed a commit
that referenced
this pull request
Jul 23, 2024
🤖 I have created a release *beep* *boop* --- ## [0.2.4](v0.2.3...v0.2.4) (2024-07-23) ### Miscellaneous * fix bundle path variable on release ([#79](#79)) ([c2ac312](c2ac312)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Racer159
added a commit
that referenced
this pull request
Jul 23, 2024
🤖 I have created a release *beep* *boop* --- ## [0.2.3](v0.2.4...v0.2.3) (2024-07-23) ### Miscellaneous * add alpha warning to Valkey package ([#73](#73)) ([5203f50](5203f50)) * add correct task includes on publish ([#81](#81)) ([eff6f2e](eff6f2e)) * add docs for databases and networking configuration for apps ([#62](#62)) ([8651574](8651574)) * add valkey to our official repositories on the README ([#71](#71)) ([f5d7450](f5d7450)) * adr for build attestations ([#76](#76)) ([8891e9f](8891e9f)) * **deps:** update swf bundle dependencies ([#53](#53)) ([6d9fe10](6d9fe10)) * **deps:** update swf bundle dependencies ([#78](#78)) ([6684e97](6684e97)) * **deps:** update swf bundle dependencies ([#83](#83)) ([4552e0f](4552e0f)) * fix bundle path variable on release ([#79](#79)) ([c2ac312](c2ac312)) * remove irrelevant comment ([#77](#77)) ([11774e8](11774e8)) * update license ([#65](#65)) ([0e692b4](0e692b4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Wayne Starr <me@racer159.com>
Racer159
added a commit
that referenced
this pull request
Jul 23, 2024
🤖 I have created a release *beep* *boop* --- ## [0.2.3](v0.2.3...v0.2.3) (2024-07-23) ### Miscellaneous * add alpha warning to Valkey package ([#73](#73)) ([5203f50](5203f50)) * add correct task includes on publish ([#81](#81)) ([eff6f2e](eff6f2e)) * add docs for databases and networking configuration for apps ([#62](#62)) ([8651574](8651574)) * add valkey to our official repositories on the README ([#71](#71)) ([f5d7450](f5d7450)) * adr for build attestations ([#76](#76)) ([8891e9f](8891e9f)) * **deps:** update swf bundle dependencies ([#53](#53)) ([6d9fe10](6d9fe10)) * **deps:** update swf bundle dependencies ([#78](#78)) ([6684e97](6684e97)) * **deps:** update swf bundle dependencies ([#83](#83)) ([4552e0f](4552e0f)) * fix bundle path variable on release ([#79](#79)) ([c2ac312](c2ac312)) * fix test task include on publish ([#84](#84)) ([425e4a5](425e4a5)) * remove irrelevant comment ([#77](#77)) ([11774e8](11774e8)) * update license ([#65](#65)) ([0e692b4](0e692b4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Wayne Starr <me@racer159.com>
This was referenced Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the bundle path variable failing on release.
Related Issue
Fixes #N/A
Type of change
Checklist before merging