fix: superchain erc20 factory merge conflicts #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* op-node,op-supervisor: feed local-unsafe/local-safe/l1-finalized data to supervisor * op-node,op-service,op-e2e: wip, fix interop op-node tests * post-rebase compilation fixes * BlockRef * op-supervisor: fix service test, cleanup todo * op-supervisor: link TODO comments to issue * interop: fix e2e action test --------- Co-authored-by: protolambda <proto@protolambda.com>
…m-optimism#12200) * 1. Added `WithRegisters` for initializing state's `Registers`. 2. Added `ThreadProofEncoder` helper function to generate `ThreadProof`. 3. Updated `AssertEVMReverts` to include `statePCs` for multiple memory requirements, added `ProofData` parameter for passing `ThreadProof`, and introduced `expectedReason` parameter for more precise testing. 4. Revised `TestEVMFault` and `TestEVM_UnsupportedSyscall` test functions to be compatible with `AssertEVMReverts`. * lint fix and comment fix * avoid false negatives * delete WithRegisters && create ProofGenerator * assert multi outputs * fix naming issue * Update cannon/mipsevm/tests/evm_multithreaded_test.go Nice catch! Co-authored-by: mbaxter <meredith.a.baxter@gmail.com> * Small fix * link check * make expectedReason a value & delete nil check --------- Co-authored-by: mbaxter <meredith.a.baxter@gmail.com>
Ports the interface checks command to go. Updates build command to execute forge fmt and the interface checks.
) * OPCM: AddressManager and ProxyAdmin assertions. * fix: Added logic for proxy types to check implementations. * fix: touch ups for RDP impl checking. * fix: fully fledged proxies added to tests because of new assertions. * fix: removing console2 lib. * fix: semgrep complaining. * fix: comment cleanup and logical split to avoid stack too deep error. * fix: adding comment back in. * fix: added natspec comments for new DeployUtils functions. * fix: removed unused imports.
Signed-off-by: Chen Kai <281165273grape@gmail.com>
Signed-off-by: Chen Kai <281165273grape@gmail.com>
Updates the dockerfile for building contracts-bedrock to use just forge-build instead of just build since just build now does a few other things for the sake of devex.
…mism#12384) Restores compatibility with the target name people are used to using for e2e tests and that is mentioned in the README and error messages etc.
Adds semgrep to ci builder and adds justfile commands to install semgrep like everything else.
* feat: add op-deployer inspect command * lint * chore: clarify arg
Adds INTERFACES.md to explain how contract interfaces are used within the contracts-bedrock package.
…thereum-optimism#12399) * use interface and deployutils for remaining contracts in l2genesis * fix semgrep errors, update semver
Slither hasn't been useful for a long time. Refer to issue ethereum-optimism#12410 for more context.
* cannon: Fix test compilation for 64-bit * cannon: Fix typo
…thereum-optimism#12382) * op-program: Store created blocks to avoid needing to re-execute them. Since op-program always creates a new block via engine_forkChoiceUpdated/engine_getPayload and then immediately sends the same block back to engine_newPayload to be imported, store the created block to the database without updating the chain head, so the engine_newPayload method is a no-op instead of having to execute the transactions again. * op-program: Add test that created block is not reprocessed on import (ethereum-optimism#12402) Also fixes differences in block hash for created payloads when using non-op stack chains.
0xDiscotech
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.