Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: better background effect in lore page and other improvements #29

Merged
merged 46 commits into from
Feb 28, 2023

Conversation

0xArdy
Copy link
Member

@0xArdy 0xArdy commented Feb 24, 2023

closes PRIUI-234
closes PRIUI-236
closes PRIUI-238
closes PRIUI-235

@aws-amplify-us-east-2
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-29.didphymyaj6l4.amplifyapp.com

@linear
Copy link

linear bot commented Feb 24, 2023

PRIUI-234 Lore ball first scroll should go under the hoop

I have divided the image so you can use them.

The ball should be:

  • Above the top part of the hoop
  • Below the bottom part of the hoop
  • Above the cone

Here are some pictures that will probably help you:

hoop-assets.zip

Can we load a sprite instead of 3 images? jeje don't hate me

PRIUI-236 Let the arrows be whiter, we don't see them if not

One option would be to remove the :hover and just leave it always on

They should be like this

image.png

Instead of like this:

image.png

@linear
Copy link

linear bot commented Feb 24, 2023

@0xArdy 0xArdy changed the title style: better background effect in lore page style: better background effect in lore page and other improvements Feb 24, 2023
@linear
Copy link

linear bot commented Feb 24, 2023

@0xArdy 0xArdy marked this pull request as ready for review February 27, 2023 19:45
@0xArdy 0xArdy requested a review from a team as a code owner February 27, 2023 19:45
@0xArdy 0xArdy merged commit e537ffb into dev Feb 28, 2023
@0xArdy 0xArdy deleted the style/better-lore-cone branch February 28, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants