fix: merkle root format #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
0xDiscotech
approved these changes
May 9, 2024
0xtiti
previously approved these changes
May 9, 2024
agusduha
reviewed
May 9, 2024
src/utils/misc.ts
Outdated
Comment on lines
36
to
54
| export function formatProofData({ merkle_root, nullifier_hash, proof }: ISuccessResult) { | ||
| // Format merkle root to bytes32 | ||
| const merkle_root_bytes32 = to32Bytes(merkle_root); | ||
|
|
||
| const [decodedMerkleRoot] = decodeAbiParameters( | ||
| parseAbiParameters('uint256 merkle_root'), | ||
| merkle_root_bytes32 as Hex, | ||
| ); | ||
| const [decodedNullifierHash] = decodeAbiParameters( | ||
| parseAbiParameters('uint256 nullifier_hash'), | ||
| nullifier_hash as Hex, | ||
| ); | ||
| const [decodedProof] = decodeAbiParameters(parseAbiParameters('uint256[8] proof'), proof as Hex); | ||
| const proofData = encodePacked( | ||
| ['uint256', 'uint256', 'uint256[8]'], | ||
| [decodedMerkleRoot, decodedNullifierHash, decodedProof], | ||
| ); | ||
| return proofData; | ||
| } |
There was a problem hiding this comment.
Why not using camel case for variables here?
There was a problem hiding this comment.
https://docs.worldcoin.org/reference/idkit#types due to how it comes from sdk
0xShaito
previously approved these changes
May 9, 2024
src/utils/misc.ts
Outdated
Comment on lines
36
to
54
| export function formatProofData({ merkle_root, nullifier_hash, proof }: ISuccessResult) { | ||
| // Format merkle root to bytes32 | ||
| const merkle_root_bytes32 = to32Bytes(merkle_root); | ||
|
|
||
| const [decodedMerkleRoot] = decodeAbiParameters( | ||
| parseAbiParameters('uint256 merkle_root'), | ||
| merkle_root_bytes32 as Hex, | ||
| ); | ||
| const [decodedNullifierHash] = decodeAbiParameters( | ||
| parseAbiParameters('uint256 nullifier_hash'), | ||
| nullifier_hash as Hex, | ||
| ); | ||
| const [decodedProof] = decodeAbiParameters(parseAbiParameters('uint256[8] proof'), proof as Hex); | ||
| const proofData = encodePacked( | ||
| ['uint256', 'uint256', 'uint256[8]'], | ||
| [decodedMerkleRoot, decodedNullifierHash, decodedProof], | ||
| ); | ||
| return proofData; | ||
| } |
| @@ -0,0 +1,10 @@ | |||
| export interface ISuccessResult { | |||
| merkle_root: string; | |||
| nullifier_hash: string; | |||
agusduha
approved these changes
May 10, 2024
0xShaito
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.