Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add data for basic #18

Merged
merged 1 commit into from
Mar 28, 2024
Merged

add data for basic #18

merged 1 commit into from
Mar 28, 2024

Conversation

wongjingping
Copy link
Collaborator

@wongjingping wongjingping commented Mar 28, 2024

Add/modify data for schema used in the basic instruct eval questions.
Note that due to the nature of the data being relative to the time when ./setup.sh was run (ie when the records were inserted into the DB), for example:

('TX039', 'C009', 'T009', NOW() - INTERVAL '1 day', 'buy', 80, 230.00, 18400.00, 'USD', 92.00, 18.00, 'KP039', TO_CHAR(NOW() - INTERVAL '1 day', '%Y%m%d %H:%i:%s'), 'pending');

Hence, we would need to re-run ./setup.sh before each evaluation run.

@wongjingping wongjingping requested a review from rishsriv March 28, 2024 03:21
Copy link
Member

@rishsriv rishsriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for going through this so carefully, and getting us the eval-able results!

@rishsriv rishsriv merged commit 184c8a8 into main Mar 28, 2024
2 checks passed
@rishsriv rishsriv deleted the jp/data branch March 28, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants